You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by tedxia <gi...@git.apache.org> on 2015/04/29 15:14:47 UTC
[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...
GitHub user tedxia opened a pull request:
https://github.com/apache/storm/pull/540
STORM-806: use storm.zookeeper.connection.timeout in storm-kafka ZkState when newCurator
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tedxia/storm use-zookeeper-connnection-timeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/540.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #540
----
commit 9a43ad611bc1c27cf977f18d9953ff9505c6f1e4
Author: xiajun <xi...@xiaomi.com>
Date: 2015-04-29T13:11:08Z
STORM-806: use storm.zookeeper.connection.timeout in storm-kafka ZkState when newCurator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...
Posted by tedxia <gi...@git.apache.org>.
Github user tedxia commented on the pull request:
https://github.com/apache/storm/pull/540#issuecomment-98583320
```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Storm ............................................. SUCCESS [0.550s]
[INFO] maven-shade-clojure-transformer ................... SUCCESS [0.840s]
[INFO] storm-maven-plugins ............................... SUCCESS [1.063s]
[INFO] multilang-javascript .............................. SUCCESS [0.105s]
[INFO] multilang-python .................................. SUCCESS [0.102s]
[INFO] multilang-ruby .................................... SUCCESS [0.096s]
[INFO] Storm Core ........................................ SUCCESS [3:48.903s]
[INFO] storm-starter ..................................... SUCCESS [2.032s]
[INFO] storm-kafka ....................................... SUCCESS [57.901s]
[INFO] storm-hdfs ........................................ SUCCESS [0.741s]
[INFO] storm-hbase ....................................... SUCCESS [0.944s]
[INFO] storm-hive ........................................ SUCCESS [50.312s]
[INFO] storm-jdbc ........................................ SUCCESS [1.186s]
[INFO] storm-redis ....................................... SUCCESS [0.209s]
[INFO] storm-eventhubs ................................... SUCCESS [2.440s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5:48.069s
[INFO] Finished at: Mon May 04 11:53:15 CST 2015
[INFO] Final Memory: 53M/925M
```
Without run multilang_test.clj, all tests pass on my machine. I don't think the change in stom-kafka will break multilang_test, will someone give some advice, thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/540#issuecomment-113997697
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/540#issuecomment-98587330
Yes, you don't need to fix current tests since it seems to be random tests failure on slow machine.
Btw, I'd like to fix kafka tests failure cause it has been occurred with very high probability.
But I don't know about Kafka so I wish someone helps me or I will learn Kafka someday and try to fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/540#issuecomment-98656146
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/540#issuecomment-97436721
Build is failed from ZkCoordinatorTest.
You should also provide Config.STORM_ZOOKEEPER_CONNECTION_TIMEOUT from ZkCoordinatorTest to let build passed.
```
private Map buildZookeeperConfig(TestingServer server) {
Map conf = new HashMap();
conf.put(Config.TRANSACTIONAL_ZOOKEEPER_PORT, server.getPort());
conf.put(Config.TRANSACTIONAL_ZOOKEEPER_SERVERS, Arrays.asList("localhost"));
conf.put(Config.STORM_ZOOKEEPER_SESSION_TIMEOUT, 20000);
conf.put(Config.STORM_ZOOKEEPER_RETRY_TIMES, 3);
conf.put(Config.STORM_ZOOKEEPER_RETRY_INTERVAL, 30);
return conf;
}
```
I recommend you to run tests from dev. machine at least once before posting PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...
Posted by tedxia <gi...@git.apache.org>.
Github user tedxia commented on the pull request:
https://github.com/apache/storm/pull/540#issuecomment-104631119
@ptgoetz Will you have a look at this, thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...
Posted by tedxia <gi...@git.apache.org>.
Github user tedxia commented on the pull request:
https://github.com/apache/storm/pull/540#issuecomment-98589471
I will try to fix STORM-798 , but how about this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...
Posted by tedxia <gi...@git.apache.org>.
Github user tedxia commented on the pull request:
https://github.com/apache/storm/pull/540#issuecomment-97647385
```
48495 [Thread-229] ERROR backtype.storm.task.ShellBolt - Halting process: ShellBolt died. Command: [ruby, tester_bolt.rb], ProcessInfo pid:7283, name:2 exitCode:-1, errorString:(Unable to capture error stream)
java.io.IOException: Stream closed
at java.io.BufferedInputStream.getBufIfOpen(BufferedInputStream.java:170) ~[na:1.8.0_31]
at java.io.BufferedInputStream.read1(BufferedInputStream.java:283) ~[na:1.8.0_31]
at java.io.BufferedInputStream.read(BufferedInputStream.java:345) ~[na:1.8.0_31]
at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284) ~[na:1.8.0_31]
at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326) ~[na:1.8.0_31]
at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178) ~[na:1.8.0_31]
at java.io.InputStreamReader.read(InputStreamReader.java:184) ~[na:1.8.0_31]
at java.io.BufferedReader.fill(BufferedReader.java:161) ~[na:1.8.0_31]
at java.io.BufferedReader.readLine(BufferedReader.java:324) ~[na:1.8.0_31]
at java.io.BufferedReader.readLine(BufferedReader.java:389) ~[na:1.8.0_31]
at backtype.storm.multilang.JsonSerializer.readString(JsonSerializer.java:179) ~[classes/:na]
at backtype.storm.multilang.JsonSerializer.readMessage(JsonSerializer.java:166) ~[classes/:na]
at backtype.storm.multilang.JsonSerializer.readShellMsg(JsonSerializer.java:100) ~[classes/:na]
at backtype.storm.utils.ShellProcess.readShellMsg(ShellProcess.java:99) ~[classes/:na]
at backtype.storm.task.ShellBolt$BoltReaderRunnable.run(ShellBolt.java:321) ~[classes/:na]
at java.lang.Thread.run(Thread.java:745) [na:1.8.0_31]
```
Test failed due to the error above, someone have idea about this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...
Posted by tedxia <gi...@git.apache.org>.
Github user tedxia commented on the pull request:
https://github.com/apache/storm/pull/540#issuecomment-97638980
@HeartSaVioR sorry about the failure in test, I had added a new patch to fix this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/540#issuecomment-97656066
30.1 is random failure of Kafka tests in Travis CI, which seems to be occurred with slow machine.
https://issues.apache.org/jira/browse/STORM-798
I can't see reason of failure about 30.2, since it doesn't print out test-report properly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/540#issuecomment-114000816
Thanks @tedxia merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/540#issuecomment-97958707
Btw, restricting log level to WARN level is only applied to storm-core now, since I didn't add logback-test.xml on any other modules. Other modules don't print out much so it can be fully printed without issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/540
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---