You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/26 11:05:09 UTC

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3187: arch: arm: kinetis: Author Gregory Nutt: update licenses to Apache

davids5 commented on a change in pull request #3187:
URL: https://github.com/apache/incubator-nuttx/pull/3187#discussion_r602191454



##########
File path: arch/arm/src/kinetis/kinetis_pwm.h
##########
@@ -79,13 +81,13 @@
 #include <arch/board/board.h>

Review comment:
       Does this matter?

##########
File path: arch/arm/src/kinetis/hardware/kinetis_usbhs.h
##########
@@ -276,557 +276,559 @@
 #define KINETIS_USBHSDCD_TIMER2_BC11                      (KINETIS_USBHSDCD_BASE + KINETIS_USBHSDCD_TIMER2_BC11_OFFSET)
 #define KINETIS_USBHSDCD_TIMER2_BC12                      (KINETIS_USBHSDCD_BASE + KINETIS_USBHSDCD_TIMER2_BC12_OFFSET)
 
-/* Register Bit-Field Definitions ***********************************************************************************/
+/* Register Bit-Field Definitions *******************************************/
 
 /* Identification Register */
 
-#define USBHS_ID_VERSIONID_SHIFT                          (29)      /* Bits 29-31: Version ID */
-#define USBHS_ID_VERSIONID_MASK                           (0x7 << USBHS_ID_VERSIONID_SHIFT)
-#define USBHS_ID_VERSION_SHIFT                            (25)      /* Bits 25-28: Version */
-#define USBHS_ID_VERSION_MASK                             (0xf << USBHS_ID_VERSION_SHIFT)
-#define USBHS_ID_REVISION_SHIFT                           (21)      /* Bits 21-24: Revision */
-#define USBHS_ID_REVISION_MASK                            (0xf << USBHS_ID_REVISION_SHIFT)
-#define USBHS_ID_TAG_SHIFT                                (16)      /* Bits 16-20: Tag */
-#define USBHS_ID_TAG_MASK                                 (0x1f << USBHS_ID_TAG_SHIFT)
-                                                                    /* Bits 14-15: Reserved */
-#define USBHS_ID_NID_SHIFT                                (8)       /* Bits 8-13: Ones complement version of ID */
-#define USBHS_ID_NID_MASK                                 (0x3f << USBHS_ID_NID_SHIFT)
-                                                                    /* Bits 6-7: Reserved */
-#define USBHS_ID_ID_SHIFT                                 (0)       /* Bits 0-5: ID Configuration number */
-#define USBHS_ID_ID_MASK                                  (0x3f << USBHS_ID_ID_SHIFT)
+#define USBHS_ID_VERSIONID_SHIFT          (29)      /* Bits 29-31: Version ID */
+#define USBHS_ID_VERSIONID_MASK           (0x7 << USBHS_ID_VERSIONID_SHIFT)
+#define USBHS_ID_VERSION_SHIFT            (25)      /* Bits 25-28: Version */
+#define USBHS_ID_VERSION_MASK             (0xf << USBHS_ID_VERSION_SHIFT)
+#define USBHS_ID_REVISION_SHIFT           (21)      /* Bits 21-24: Revision */
+#define USBHS_ID_REVISION_MASK            (0xf << USBHS_ID_REVISION_SHIFT)
+#define USBHS_ID_TAG_SHIFT                (16)      /* Bits 16-20: Tag */
+#define USBHS_ID_TAG_MASK                 (0x1f << USBHS_ID_TAG_SHIFT)
+                                                    /* Bits 14-15: Reserved */
+#define USBHS_ID_NID_SHIFT                (8)       /* Bits 8-13: Ones complement version of ID */
+#define USBHS_ID_NID_MASK                 (0x3f << USBHS_ID_NID_SHIFT)
+                                                    /* Bits 6-7: Reserved */
+#define USBHS_ID_ID_SHIFT                 (0)       /* Bits 0-5: ID Configuration number */
+#define USBHS_ID_ID_MASK                  (0x3f << USBHS_ID_ID_SHIFT)
 
 /* General Hardware Parameters Register */
 
-                                                                    /* Bits 11-31: Reserved */
-#define USBHS_HWGENERAL_SM_SHIFT                          (9)       /* Bits 9-10: Serial mode */
-#define USBHS_HWGENERAL_SM_MASK                           (0x3 << USBHS_HWGENERAL_SM_SHIFT)
-#define USBHS_HWGENERAL_PHYM_SHIFT                        (6)       /* Bits 6-8: PHY Mode */
-#define USBHS_HWGENERAL_PHYM_MASK                         (0x7 << USBHS_HWGENERAL_PHYM_SHIFT)
-#define USBHS_HWGENERAL_PHYW_SHIFT                        (4)       /* Bits 4-5: PHY Width */
-#define USBHS_HWGENERAL_PHYW_MASK                         (0x3 << USBHS_HWGENERAL_PHYW_SHIFT)
-                                                                    /* Bits 0-3: Reserved */
+                                                  /* Bits 11-31:  Reserved */
+#define USBHS_HWGENERAL_SM_SHIFT          (9)       /* Bits 9-10: Serial mode */
+#define USBHS_HWGENERAL_SM_MASK           (0x3 << USBHS_HWGENERAL_SM_SHIFT)
+#define USBHS_HWGENERAL_PHYM_SHIFT        (6)       /* Bits 6-8: PHY Mode */
+#define USBHS_HWGENERAL_PHYM_MASK         (0x7 << USBHS_HWGENERAL_PHYM_SHIFT)
+#define USBHS_HWGENERAL_PHYW_SHIFT        (4)       /* Bits 4-5: PHY Width */
+#define USBHS_HWGENERAL_PHYW_MASK         (0x3 << USBHS_HWGENERAL_PHYW_SHIFT)
+                                                    /* Bits 0-3: Reserved */
 
 /* Host Hardware Parameters Register */
 
-#define USBHS_HWHOST_TTPER_SHIFT                          (24)      /* Bits 24-31: Transaction translator periodic contexts */
-#define USBHS_HWHOST_TTPER_MASK                           (0xff << USBHS_HWHOST_TTPER_SHIFT)
-#define USBHS_HWHOST_TTASY_SHIFT                          (16)      /* Bits 16-23: Transaction translator contexts */
-#define USBHS_HWHOST_TTASY_MASK                           (0xff << USBHS_HWHOST_TTASY_SHIFT)
-                                                                    /* Bits 5-14: Reserved */
-#define USBHS_HWHOST_NPORT_SHIFT                          (1)       /* Bits 1-3: Number of Ports */
-#define USBHS_HWHOST_NPORT_MASK                           (0x7 << USBHS_HWHOST_NPORT_SHIFT)
-#define USBHS_HWHOST_HC                                   (1 << 0)  /* Bit 0: Host Capable */
+#define USBHS_HWHOST_TTPER_SHIFT          (24)      /* Bits 24-31: Transaction translator periodic contexts */
+#define USBHS_HWHOST_TTPER_MASK           (0xff << USBHS_HWHOST_TTPER_SHIFT)
+#define USBHS_HWHOST_TTASY_SHIFT          (16)      /* Bits 16-23: Transaction translator contexts */
+#define USBHS_HWHOST_TTASY_MASK           (0xff << USBHS_HWHOST_TTASY_SHIFT)
+                                                    /* Bits 5-14: Reserved */
+#define USBHS_HWHOST_NPORT_SHIFT          (1)       /* Bits 1-3: Number of Ports */
+#define USBHS_HWHOST_NPORT_MASK           (0x7 << USBHS_HWHOST_NPORT_SHIFT)
+#define USBHS_HWHOST_HC                   (1 << 0)  /* Bit 0: Host Capable */
 
 /* Device Hardware Parameters Register */
 
-                                                                    /* Bits 6-31: Reserved */
-#define USBHS_HWDEVICE_DEVEP_SHIFT                        (1)       /* Bits 1-5: Device endpoints */
-#define USBHS_HWDEVICE_DEVEP_MASK                         (0x1f << USBHS_HWDEVICE_DEVEP_SHIFT)
-#define USBHS_HWDEVICE_DC                                 (1 << 0)  /* Bit 0: Device Capable */
+                                                    /* Bits 6-31: Reserved */
+#define USBHS_HWDEVICE_DEVEP_SHIFT        (1)       /* Bits 1-5: Device endpoints */
+#define USBHS_HWDEVICE_DEVEP_MASK         (0x1f << USBHS_HWDEVICE_DEVEP_SHIFT)
+#define USBHS_HWDEVICE_DC                 (1 << 0)  /* Bit 0: Device Capable */
 
 /* Transmit Buffer Hardware Parameters Register */
 
-#define USBHS_HWTXBUF_TXLC                                (1 << 31) /* Bit 31: Transmit local Context Registers */
-                                                                    /* Bits 24-30: Reserved */
-#define USBHS_HWTXBUF_TXCHANADD_SHIFT                     (16)      /* Bits 16-23: Transmit Channel Address */
-#define USBHS_HWTXBUF_TXCHANADD_MASK                      (0xff << USBHS_HWTXBUF_TXCHANADD_SHIFT)
-#define USBHS_HWTXBUF_TXADD_SHIFT                         (8)       /* Bits 8-15: Transmit Address */
-#define USBHS_HWTXBUF_TXADD_MASK                          (0xff << USBHS_HWTXBUF_TXADD_SHIFT)
-#define USBHS_HWTXBUF_TXBURST_SHIFT                       (0)       /* Bits 0-7: Transmit Burst */
-#define USBHS_HWTXBUF_TXBURST_MASK                        (0xff << USBHS_HWTXBUF_TXBURST_SHIFT)
+#define USBHS_HWTXBUF_TXLC                (1 << 31) /* Bit 31: Transmit local Context Registers */
+                                                    /* Bits 24-30: Reserved */
+#define USBHS_HWTXBUF_TXCHANADD_SHIFT     (16)      /* Bits 16-23: Transmit Channel Address */
+#define USBHS_HWTXBUF_TXCHANADD_MASK      (0xff << USBHS_HWTXBUF_TXCHANADD_SHIFT)
+#define USBHS_HWTXBUF_TXADD_SHIFT         (8)       /* Bits 8-15: Transmit Address */
+#define USBHS_HWTXBUF_TXADD_MASK          (0xff << USBHS_HWTXBUF_TXADD_SHIFT)
+#define USBHS_HWTXBUF_TXBURST_SHIFT       (0)       /* Bits 0-7: Transmit Burst */
+#define USBHS_HWTXBUF_TXBURST_MASK        (0xff << USBHS_HWTXBUF_TXBURST_SHIFT)
 
 /* Receive Buffer Hardware Parameters Register */
 
-                                                                    /* Bits 16-31: Reserved */
-#define USBHS_HWRXBUF_RXADD_SHIFT                         (8)       /* Bits 8-15: Receive Address */
-#define USBHS_HWRXBUF_RXADD_MASK                          (0xff << USBHS_HWRXBUF_RXADD_SHIFT)
-#define USBHS_HWRXBUF_RXBURST_SHIFT                       (0)       /* Bits 0-7: Receive Burst */
-#define USBHS_HWRXBUF_RXBURST_MASK                        (0xff << USBHS_HWRXBUF_RXBURST_SHIFT)
+                                                /* Bits 16-31: Reserved */
+#define USBHS_HWRXBUF_RXADD_SHIFT         (8)       /* Bits 8-15: Receive Address */
+#define USBHS_HWRXBUF_RXADD_MASK          (0xff << USBHS_HWRXBUF_RXADD_SHIFT)
+#define USBHS_HWRXBUF_RXBURST_SHIFT       (0)       /* Bits 0-7: Receive Burst */
+#define USBHS_HWRXBUF_RXBURST_MASK        (0xff << USBHS_HWRXBUF_RXBURST_SHIFT)
 
 /* General Purpose Timer n Load Register */
 
-                                                                    /* Bits 24-31: Reserved */
-#define USBHS_GPTIMERnLD_GPTLD_SHIFT                      (0)       /* Bits 0-23: Value to be loaded into the countdown timer on reset */
-#define USBHS_GPTIMERnLD_GPTLD_MASK                       (0xffffff << USBHS_GPTIMERnLD_GPTLD_SHIFT)
+                                                /* Bits 24-31: Reserved */
+#define USBHS_GPTIMERnLD_GPTLD_SHIFT      (0)       /* Bits 0-23: Value to be loaded into the countdown timer on reset */
+#define USBHS_GPTIMERnLD_GPTLD_MASK       (0xffffff << USBHS_GPTIMERnLD_GPTLD_SHIFT)
 
 /* General Purpose Timer n Control Register */
 
-#define USBHS_GPTIMERnCTL_RUN                             (1 << 31) /* Bit 31: Timer Run */
-#define USBHS_GPTIMERnCTL_RST                             (1 << 30) /* Bit 30: Timer Reset */
-                                                                    /* Bits 25-29: Reserved */
-#define USBHS_GPTIMERnCTL_MODE                            (1 << 24) /* Bit 24: Timer Mode */
-#define USBHS_GPTIMERnCTL_GPTCNT_SHIFT                    (0)       /* Bits 0-23: Timer Count */
-#define USBHS_GPTIMERnCTL_GPTCNT_MASK                     (0xffffff << USBHS_GPTIMERnCTL_GPTCNT_SHIFT)
+#define USBHS_GPTIMERnCTL_RUN             (1 << 31) /* Bit 31: Timer Run */

Review comment:
       We have some mixed case. Sad cus this will not be as readable with a cap N




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org