You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/08/02 18:39:42 UTC
[kudu-CR] KUDU-2671 fix updating partition end keys for unbounded ranges
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18808
Change subject: KUDU-2671 fix updating partition end keys for unbounded ranges
......................................................................
KUDU-2671 fix updating partition end keys for unbounded ranges
This patch fixes an issue with updating the hash bucket components for
partitions' end keys in case of unbounded ranges. I also added new test
scenarios that allowed to spot the issue. The newly added scenarios
would fail if not including the fix. In addition, I updated a few other
test scenarios to match the current logic of updating the hash partition
component of partition end key.
The previous implementation of updating the hash components tried to
avoid holes in the partition keyspace by carrying over iotas to next
hash dimension index, but with the introduction of range-specific hash
schemas it's no longer possible to do so while keeping the result
key ranges disjoint.
For example, consider the following partitioning:
[-inf, 0) x 3 buckets x 3 buckets; [0, +inf) x 2 buckets x 2 buckets
The original set of ranges looks like the following:
[ (0, 0, ""), (0, 0, "0") )
[ (0, 1, ""), (0, 1, "0") )
[ (0, 2, ""), (0, 2, "0") )
[ (1, 0, ""), (1, 0, "0") )
[ (1, 1, ""), (1, 1, "0") )
[ (1, 2, ""), (1, 2, "0") )
[ (2, 0, ""), (2, 0, "0") )
[ (2, 1, ""), (2, 1, "0") )
[ (2, 2, ""), (2, 2, "0") )
[ (0, 0, "0"), (0, 0, "") )
[ (0, 1, "0"), (0, 1, "") )
[ (1, 0, "0"), (1, 0, "") )
[ (1, 1, "0"), (1, 1, "") )
The previous implementation would transform partition the key range
[ (0, 1, "0"), (0, 1, "") ) into [ (0, 1, "0"), (1, 0, "") ), but
that would put they key range [ (0, 2, ""), (0, 2, "0") ) inside the
transformed one. That would mess up the interval logic of the partition
pruning and the client's metacache.
As it turns out, the continuous keyspace was just a nice thing to have
since the partition prunning and the client metacache work fine with
sparse keyspaces as well.
Change-Id: I3775f914a3b7cdc294a26911663c2d848f4e491b
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
4 files changed, 274 insertions(+), 61 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/18808/1
--
To view, visit http://gerrit.cloudera.org:8080/18808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3775f914a3b7cdc294a26911663c2d848f4e491b
Gerrit-Change-Number: 18808
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-2671 fix updating partition end keys for unbounded ranges
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18808 )
Change subject: KUDU-2671 fix updating partition end keys for unbounded ranges
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3775f914a3b7cdc294a26911663c2d848f4e491b
Gerrit-Change-Number: 18808
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 02:30:22 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 fix updating partition end keys for unbounded ranges
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18808
to look at the new patch set (#4).
Change subject: KUDU-2671 fix updating partition end keys for unbounded ranges
......................................................................
KUDU-2671 fix updating partition end keys for unbounded ranges
This patch fixes an issue with updating the hash bucket components for
partitions' end keys in case of unbounded ranges. I also added new test
scenarios that allowed to spot the issue. The newly added scenarios
would fail if not including the fix. In addition, I updated a few other
test scenarios to match the current logic of updating the hash partition
component of partition end key.
The previous implementation of updating the hash components tried to
avoid holes in the partition keyspace by carrying over iotas to next
hash dimension index, but with the introduction of range-specific hash
schemas it's no longer possible to do so while keeping the result
key ranges disjoint.
For example, consider the following partitioning:
[-inf, 0) x 3 buckets x 3 buckets; [0, +inf) x 2 buckets x 2 buckets
The original set of ranges looks like the following:
[ (0, 0, ""), (0, 0, "0") )
[ (0, 1, ""), (0, 1, "0") )
[ (0, 2, ""), (0, 2, "0") )
[ (1, 0, ""), (1, 0, "0") )
[ (1, 1, ""), (1, 1, "0") )
[ (1, 2, ""), (1, 2, "0") )
[ (2, 0, ""), (2, 0, "0") )
[ (2, 1, ""), (2, 1, "0") )
[ (2, 2, ""), (2, 2, "0") )
[ (0, 0, "0"), (0, 0, "") )
[ (0, 1, "0"), (0, 1, "") )
[ (1, 0, "0"), (1, 0, "") )
[ (1, 1, "0"), (1, 1, "") )
The previous implementation would transform the key range
[ (0, 1, "0"), (0, 1, "") ) into [ (0, 1, "0"), (1, 0, "") ), but
that would put the key range [ (0, 2, ""), (0, 2, "0") ) inside the
transformed one. That would mess up the interval logic of the partition
pruning and the client's metacache.
As it turns out, the continuous keyspace was just a nice thing to have
since the partition pruning and the client metacache work fine with
sparse keyspaces as well.
Change-Id: I3775f914a3b7cdc294a26911663c2d848f4e491b
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
4 files changed, 279 insertions(+), 65 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/18808/4
--
To view, visit http://gerrit.cloudera.org:8080/18808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3775f914a3b7cdc294a26911663c2d848f4e491b
Gerrit-Change-Number: 18808
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 fix updating partition end keys for unbounded ranges
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18808 )
Change subject: KUDU-2671 fix updating partition end keys for unbounded ranges
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3775f914a3b7cdc294a26911663c2d848f4e491b
Gerrit-Change-Number: 18808
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 17:40:41 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 fix updating partition end keys for unbounded ranges
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18808 )
Change subject: KUDU-2671 fix updating partition end keys for unbounded ranges
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3775f914a3b7cdc294a26911663c2d848f4e491b
Gerrit-Change-Number: 18808
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 18:46:16 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 fix updating partition end keys for unbounded ranges
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18808 )
Change subject: KUDU-2671 fix updating partition end keys for unbounded ranges
......................................................................
KUDU-2671 fix updating partition end keys for unbounded ranges
This patch fixes an issue with updating the hash bucket components for
partitions' end keys in case of unbounded ranges. I also added new test
scenarios that allowed to spot the issue. The newly added scenarios
would fail if not including the fix. In addition, I updated a few other
test scenarios to match the current logic of updating the hash partition
component of partition end key.
The previous implementation of updating the hash components tried to
avoid holes in the partition keyspace by carrying over iotas to next
hash dimension index, but with the introduction of range-specific hash
schemas it's no longer possible to do so while keeping the result
key ranges disjoint.
For example, consider the following partitioning:
[-inf, 0) x 3 buckets x 3 buckets; [0, +inf) x 2 buckets x 2 buckets
The original set of ranges looks like the following:
[ (0, 0, ""), (0, 0, "0") )
[ (0, 1, ""), (0, 1, "0") )
[ (0, 2, ""), (0, 2, "0") )
[ (1, 0, ""), (1, 0, "0") )
[ (1, 1, ""), (1, 1, "0") )
[ (1, 2, ""), (1, 2, "0") )
[ (2, 0, ""), (2, 0, "0") )
[ (2, 1, ""), (2, 1, "0") )
[ (2, 2, ""), (2, 2, "0") )
[ (0, 0, "0"), (0, 0, "") )
[ (0, 1, "0"), (0, 1, "") )
[ (1, 0, "0"), (1, 0, "") )
[ (1, 1, "0"), (1, 1, "") )
The previous implementation would transform the key range
[ (0, 1, "0"), (0, 1, "") ) into [ (0, 1, "0"), (1, 0, "") ), but
that would put the key range [ (0, 2, ""), (0, 2, "0") ) inside the
transformed one. That would mess up the interval logic of the partition
pruning and the client's metacache.
As it turns out, the continuous keyspace was just a nice thing to have
since the partition pruning and the client metacache work fine with
sparse keyspaces as well.
Change-Id: I3775f914a3b7cdc294a26911663c2d848f4e491b
Reviewed-on: http://gerrit.cloudera.org:8080/18808
Tested-by: Kudu Jenkins
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
4 files changed, 279 insertions(+), 65 deletions(-)
Approvals:
Kudu Jenkins: Verified
Mahesh Reddy: Looks good to me, but someone else must approve
Abhishek Chennaka: Looks good to me, but someone else must approve
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3775f914a3b7cdc294a26911663c2d848f4e491b
Gerrit-Change-Number: 18808
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 fix updating partition end keys for unbounded ranges
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18808
to look at the new patch set (#2).
Change subject: KUDU-2671 fix updating partition end keys for unbounded ranges
......................................................................
KUDU-2671 fix updating partition end keys for unbounded ranges
This patch fixes an issue with updating the hash bucket components for
partitions' end keys in case of unbounded ranges. I also added new test
scenarios that allowed to spot the issue. The newly added scenarios
would fail if not including the fix. In addition, I updated a few other
test scenarios to match the current logic of updating the hash partition
component of partition end key.
The previous implementation of updating the hash components tried to
avoid holes in the partition keyspace by carrying over iotas to next
hash dimension index, but with the introduction of range-specific hash
schemas it's no longer possible to do so while keeping the result
key ranges disjoint.
For example, consider the following partitioning:
[-inf, 0) x 3 buckets x 3 buckets; [0, +inf) x 2 buckets x 2 buckets
The original set of ranges looks like the following:
[ (0, 0, ""), (0, 0, "0") )
[ (0, 1, ""), (0, 1, "0") )
[ (0, 2, ""), (0, 2, "0") )
[ (1, 0, ""), (1, 0, "0") )
[ (1, 1, ""), (1, 1, "0") )
[ (1, 2, ""), (1, 2, "0") )
[ (2, 0, ""), (2, 0, "0") )
[ (2, 1, ""), (2, 1, "0") )
[ (2, 2, ""), (2, 2, "0") )
[ (0, 0, "0"), (0, 0, "") )
[ (0, 1, "0"), (0, 1, "") )
[ (1, 0, "0"), (1, 0, "") )
[ (1, 1, "0"), (1, 1, "") )
The previous implementation would transform partition the key range
[ (0, 1, "0"), (0, 1, "") ) into [ (0, 1, "0"), (1, 0, "") ), but
that would put they key range [ (0, 2, ""), (0, 2, "0") ) inside the
transformed one. That would mess up the interval logic of the partition
pruning and the client's metacache.
As it turns out, the continuous keyspace was just a nice thing to have
since the partition prunning and the client metacache work fine with
sparse keyspaces as well.
Change-Id: I3775f914a3b7cdc294a26911663c2d848f4e491b
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
4 files changed, 278 insertions(+), 64 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/18808/2
--
To view, visit http://gerrit.cloudera.org:8080/18808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3775f914a3b7cdc294a26911663c2d848f4e491b
Gerrit-Change-Number: 18808
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 fix updating partition end keys for unbounded ranges
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18808 )
Change subject: KUDU-2671 fix updating partition end keys for unbounded ranges
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/18808/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18808/2//COMMIT_MSG@41
PS2, Line 41: the key range
> nit: the partition
Done
http://gerrit.cloudera.org:8080/#/c/18808/2//COMMIT_MSG@43
PS2, Line 43: they
> nit: the
Done
http://gerrit.cloudera.org:8080/#/c/18808/2/src/kudu/common/partition.cc
File src/kudu/common/partition.cc:
http://gerrit.cloudera.org:8080/#/c/18808/2/src/kudu/common/partition.cc@1499
PS2, Line 1499: the way
> nit: remove 'the way'
Done
http://gerrit.cloudera.org:8080/#/c/18808/2/src/kudu/common/partition.cc@1500
PS2, Line 1500: compared
> nit: add comma after 'compared'
Done
--
To view, visit http://gerrit.cloudera.org:8080/18808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3775f914a3b7cdc294a26911663c2d848f4e491b
Gerrit-Change-Number: 18808
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Aug 2022 23:40:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671 fix updating partition end keys for unbounded ranges
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18808
to look at the new patch set (#3).
Change subject: KUDU-2671 fix updating partition end keys for unbounded ranges
......................................................................
KUDU-2671 fix updating partition end keys for unbounded ranges
This patch fixes an issue with updating the hash bucket components for
partitions' end keys in case of unbounded ranges. I also added new test
scenarios that allowed to spot the issue. The newly added scenarios
would fail if not including the fix. In addition, I updated a few other
test scenarios to match the current logic of updating the hash partition
component of partition end key.
The previous implementation of updating the hash components tried to
avoid holes in the partition keyspace by carrying over iotas to next
hash dimension index, but with the introduction of range-specific hash
schemas it's no longer possible to do so while keeping the result
key ranges disjoint.
For example, consider the following partitioning:
[-inf, 0) x 3 buckets x 3 buckets; [0, +inf) x 2 buckets x 2 buckets
The original set of ranges looks like the following:
[ (0, 0, ""), (0, 0, "0") )
[ (0, 1, ""), (0, 1, "0") )
[ (0, 2, ""), (0, 2, "0") )
[ (1, 0, ""), (1, 0, "0") )
[ (1, 1, ""), (1, 1, "0") )
[ (1, 2, ""), (1, 2, "0") )
[ (2, 0, ""), (2, 0, "0") )
[ (2, 1, ""), (2, 1, "0") )
[ (2, 2, ""), (2, 2, "0") )
[ (0, 0, "0"), (0, 0, "") )
[ (0, 1, "0"), (0, 1, "") )
[ (1, 0, "0"), (1, 0, "") )
[ (1, 1, "0"), (1, 1, "") )
The previous implementation would transform the key range
[ (0, 1, "0"), (0, 1, "") ) into [ (0, 1, "0"), (1, 0, "") ), but
that would put they key range [ (0, 2, ""), (0, 2, "0") ) inside the
transformed one. That would mess up the interval logic of the partition
pruning and the client's metacache.
As it turns out, the continuous keyspace was just a nice thing to have
since the partition pruning and the client metacache work fine with
sparse keyspaces as well.
Change-Id: I3775f914a3b7cdc294a26911663c2d848f4e491b
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
4 files changed, 279 insertions(+), 65 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/18808/3
--
To view, visit http://gerrit.cloudera.org:8080/18808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3775f914a3b7cdc294a26911663c2d848f4e491b
Gerrit-Change-Number: 18808
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 fix updating partition end keys for unbounded ranges
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18808 )
Change subject: KUDU-2671 fix updating partition end keys for unbounded ranges
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/18808/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18808/2//COMMIT_MSG@41
PS2, Line 41: the key range
nit: the partition
http://gerrit.cloudera.org:8080/#/c/18808/2//COMMIT_MSG@43
PS2, Line 43: they
nit: the
http://gerrit.cloudera.org:8080/#/c/18808/2/src/kudu/common/partition.cc
File src/kudu/common/partition.cc:
http://gerrit.cloudera.org:8080/#/c/18808/2/src/kudu/common/partition.cc@1499
PS2, Line 1499: the way
nit: remove 'the way'
http://gerrit.cloudera.org:8080/#/c/18808/2/src/kudu/common/partition.cc@1500
PS2, Line 1500: compared
nit: add comma after 'compared'
--
To view, visit http://gerrit.cloudera.org:8080/18808
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3775f914a3b7cdc294a26911663c2d848f4e491b
Gerrit-Change-Number: 18808
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Aug 2022 22:20:14 +0000
Gerrit-HasComments: Yes