You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/11/25 21:33:37 UTC

[GitHub] [skywalking-satellite] hanahmily commented on a change in pull request #4: init satellite project

hanahmily commented on a change in pull request #4:
URL: https://github.com/apache/skywalking-satellite/pull/4#discussion_r530653144



##########
File path: .github/workflows/build-and-test.yaml
##########
@@ -21,15 +21,25 @@ on:
   push:
     branches:
       - main
-    paths:
-      - '!**.md'
 
 jobs:
   build:
     runs-on: ubuntu-18.04
     timeout-minutes: 90
+    strategy:
+      matrix:
+        go-version: [1.14, 1.15]
+      fail-fast: true
     steps:
-      - uses: actions/checkout@v2
+      - name: Set up Go ${{ matrix.go-version }}
+        uses: actions/setup-go@v1

Review comment:
       In the new project, my preference is we should opt to [setup-go@v2](https://github.com/actions/setup-go#v2)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org