[GitHub] [iceberg] kbendick commented on a change in pull request #2641: Hive: Improve code style

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #2641:
URL: https://github.com/apache/iceberg/pull/2641#discussion_r640322831



##########
File path: mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
##########
@@ -232,7 +232,7 @@ public void abortJob(JobContext originalContext, int status) throws IOException
           .executeWith(tableExecutor)
           .onFailure((output, exc) -> LOG.warn("Failed cleanup table {} on abort job", output, exc))
           .run(output -> {
-            LOG.info("Cleaning job for table {}", jobContext.getJobID(), output);
+            LOG.info("Cleaning job for table {} {}", jobContext.getJobID(), output);

Review comment:
       Good catch 👍.
   
   I seem to remember there being some sort of analyzer annotation or something to ensure the correct number of arguments, but for the life of me can't recall. Probably wouldn't be related to this case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org