You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kie.apache.org by "rgdoliveira (via GitHub)" <gi...@apache.org> on 2025/02/14 13:48:27 UTC

[PR] NO-ISSUE: update go from 1.22.9 to 1.22.12 to address recently CVEs on Go [incubator-kie-tools]

rgdoliveira opened a new pull request, #2909:
URL: https://github.com/apache/incubator-kie-tools/pull/2909

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: update go from 1.22.9 to 1.22.12 to address recently CVEs [incubator-kie-tools]

Posted by "ljmotta (via GitHub)" <gi...@apache.org>.

ljmotta commented on PR #2909:
URL: https://github.com/apache/incubator-kie-tools/pull/2909#issuecomment-2659984530

   Well, actually, if the CI is using the 1.22.12, all artifacts are generated with this new Golang version, so I don't think we need to update all `go.mod` files. What concerns me is the difference in the `toolchain` version of the `kn-plugin-workflow`. From the Golang docs [1]. From what I understood, declaring a version bigger than the one installed, will download this new version. So this update will not affect the `kn-plugin-workflow`.
   
   [1] https://go.dev/doc/toolchain


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: update go from 1.22.9 to 1.22.12 to address recently CVEs [incubator-kie-tools]

Posted by "rgdoliveira (via GitHub)" <gi...@apache.org>.

rgdoliveira commented on PR #2909:
URL: https://github.com/apache/incubator-kie-tools/pull/2909#issuecomment-2659547899

   @ljmotta I see, like in following files (also others) there is go 1.21 defined:
   packages/dev-deployment-upload-service/go.mod
   packages/extended-services/go.mod
   
    I'm not an expert in kie-tools repo and I don't know where those packages are used. but thats a good point if all package should be aligned to the same go version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: update go from 1.22.9 to 1.22.12 to address recently CVEs [incubator-kie-tools]

Posted by "ljmotta (via GitHub)" <gi...@apache.org>.

ljmotta commented on PR #2909:
URL: https://github.com/apache/incubator-kie-tools/pull/2909#issuecomment-2659479785

   @rgdoliveira Hey there! thanks for addressing this. I have a question regarding these go upgrades. Shouldn't we upgrade the `go.mod` files of the packages too? Some packages are with the go version `1.21`, and some use the `toolchain` of `1.23.x`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: update go from 1.22.9 to 1.22.12 to address recently CVEs [incubator-kie-tools]

Posted by "rgdoliveira (via GitHub)" <gi...@apache.org>.

rgdoliveira commented on PR #2909:
URL: https://github.com/apache/incubator-kie-tools/pull/2909#issuecomment-2665642713

   Do you think we can merge this one and discuss about the `kn-plugin-workflow` some other place?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: update go from 1.22.9 to 1.22.12 to address recently CVEs [incubator-kie-tools]

Posted by "rgdoliveira (via GitHub)" <gi...@apache.org>.

rgdoliveira merged PR #2909:
URL: https://github.com/apache/incubator-kie-tools/pull/2909


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: update go from 1.22.9 to 1.22.12 to address recently CVEs [incubator-kie-tools]

Posted by "ljmotta (via GitHub)" <gi...@apache.org>.

ljmotta commented on PR #2909:
URL: https://github.com/apache/incubator-kie-tools/pull/2909#issuecomment-2665871873

   @rgdoliveira I think we can. After some research, the `toolchain go1.23.4` will download the `1.23.4` toolchain but will not set it as default.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: update go from 1.22.9 to 1.22.12 to address recently CVEs [incubator-kie-tools]

Posted by "domhanak (via GitHub)" <gi...@apache.org>.

domhanak commented on PR #2909:
URL: https://github.com/apache/incubator-kie-tools/pull/2909#issuecomment-2660907843

   @treblereel fyi


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org