You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/05 15:53:35 UTC

[GitHub] [beam] chamikaramj commented on a change in pull request #11048: [BEAM-9433] Create expansion service artifact for common Java IOs.

chamikaramj commented on a change in pull request #11048: [BEAM-9433] Create expansion service artifact for common Java IOs.
URL: https://github.com/apache/beam/pull/11048#discussion_r388382885
 
 

 ##########
 File path: sdks/python/apache_beam/io/external/kafka.py
 ##########
 @@ -57,6 +58,10 @@
     ])
 
 
+def default_io_expansion_service():
+  return BeamJarExpansionService('sdks:java:io:expansion-service:shadowJar')
 
 Review comment:
   Can we add some unit tests for BeamJarExpansionService and JavaJarExpansionService ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services