You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by davebshow <gi...@git.apache.org> on 2017/11/15 18:20:35 UTC
[GitHub] tinkerpop pull request #749: Tinkerpop 1807 Gremlin-Python doesn't support G...
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/749
Tinkerpop 1807 Gremlin-Python doesn't support GraphSON types g:Date, g:Timestamp and g:UUID
https://issues.apache.org/jira/browse/TINKERPOP-1807
This PR follows #741, adding support for core types Date, Timestamp, and UUID in GraphSON3
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1807-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/749.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #749
----
commit 3b651ff58cdf210a63a0101d0a311c7076de2b0e
Author: davebshow <da...@gmail.com>
Date: 2017-11-01T23:31:10Z
Implemented support for missing core GraphSON types in gremlin-python
commit 4661284292306fecb67fbcc46617af97b3b7762f
Author: davebshow <da...@gmail.com>
Date: 2017-11-07T17:40:05Z
updated changelog and upgrade docs
commit c0078cc172e918f96460630da27ff04cb4e9478d
Author: davebshow <da...@gmail.com>
Date: 2017-11-13T18:11:46Z
added asserts to check values are deserialized as expected
commit 5031ccdbea28b1384c40fd522e9fec25b5b86818
Author: davebshow <da...@gmail.com>
Date: 2017-11-15T18:12:22Z
added core GraphSON types UUID, Date, and Timestamp for GraphSON 3
commit ed6133e502e573650a39a6ac96c4a901e168c2e6
Author: davebshow <da...@gmail.com>
Date: 2017-11-15T18:17:34Z
fixed typo in changelog
commit 80624fcbe34ffb0d4d2a4033926a198096413ae3
Author: davebshow <da...@gmail.com>
Date: 2017-11-15T18:19:59Z
removed unwanted blank line
----
---
[GitHub] tinkerpop issue #749: Tinkerpop 1807 Gremlin-Python doesn't support GraphSON...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/749
You don't need a changelog for 3.3.1. we isolate the fix to the earliest release it was fixed on.
---
[GitHub] tinkerpop issue #749: Tinkerpop 1807 Gremlin-Python doesn't support GraphSON...
Posted by davebshow <gi...@git.apache.org>.
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/749
Does this need a changelog for 3.3.1 as well, or are the 3.2.7 changes assumed to be included in 3.3.1?
---
[GitHub] tinkerpop issue #749: Tinkerpop 1807 Gremlin-Python doesn't support GraphSON...
Posted by davebshow <gi...@git.apache.org>.
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/749
Done. VOTE +1
---
[GitHub] tinkerpop issue #749: Tinkerpop 1807 Gremlin-Python doesn't support GraphSON...
Posted by FlorianHockmann <gi...@git.apache.org>.
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/749
VOTE +1
---
[GitHub] tinkerpop pull request #749: Tinkerpop 1807 Gremlin-Python doesn't support G...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/749
---
[GitHub] tinkerpop pull request #749: Tinkerpop 1807 Gremlin-Python doesn't support G...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/749#discussion_r151390209
--- Diff: docs/src/upgrade/release-3.3.x.asciidoc ---
@@ -29,6 +29,15 @@ Please see the link:https://github.com/apache/tinkerpop/blob/3.3.1/CHANGELOG.asc
=== Upgrading for Users
+==== Gremlin-Python Core Types
--- End diff --
You can remove this - no need to duplicate it. We direct users to 3.2.x upgrade notes as being inclusive of the 3.3.x ones.
---
[GitHub] tinkerpop issue #749: Tinkerpop 1807 Gremlin-Python doesn't support GraphSON...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/749
VOTE +1
---