You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Vyacheslav Koptilin (Jira)" <ji...@apache.org> on 2022/09/09 11:25:00 UTC
[jira] [Commented] (IGNITE-17510) NPE in cluster configuration REST calls
[ https://issues.apache.org/jira/browse/IGNITE-17510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602273#comment-17602273 ]
Vyacheslav Koptilin commented on IGNITE-17510:
----------------------------------------------
Hello [~vpakhnushev],
In general the patch looks good. However, please take a look at https://github.com/apache/ignite-3/pull/1037/files#r966923583
> NPE in cluster configuration REST calls
> ---------------------------------------
>
> Key: IGNITE-17510
> URL: https://issues.apache.org/jira/browse/IGNITE-17510
> Project: Ignite
> Issue Type: Task
> Components: cli, rest
> Reporter: Aleksandr
> Assignee: Vadim Pakhnushev
> Priority: Major
> Labels: ignite-3
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When calling {{/management/v1/configuration/cluster}} on the cluster that is not initialized, then we got the NPE and as a result, a 500 error code is returned.
> {{ItNotInitializedClusterRestTest#clusterConfiguration}} and {{ItNotInitializedClusterRestTest#clusterConfigurationUpdate}} reproduce the issue and have TODO for that.
> I would suggest to return 404 in that case as {{/management/v1/cluster/topology/logical}} does. So, there is no such resource on the cluster that is not initialized.
> The {{cluster config show/update}} error handling should be updated as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)