You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/12/18 21:03:21 UTC
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8865
Change subject: IMPALA-2181: [DOCS] Document changes to SET output
......................................................................
IMPALA-2181: [DOCS] Document changes to SET output
Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
---
M docs/topics/impala_set.xml
1 file changed, 73 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/8865/1
--
To view, visit http://gerrit.cloudera.org:8080/8865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
Gerrit-Change-Number: 8865
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 )
Change subject: IMPALA-2181: [DOCS] Document changes to SET output
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8865/2/docs/topics/impala_set.xml
File docs/topics/impala_set.xml:
http://gerrit.cloudera.org:8080/#/c/8865/2/docs/topics/impala_set.xml@214
PS2, Line 214: Query options (defaults shown in []):
: ABORT_ON_DEFAULT_LIMIT_EXCEEDED: [0]
: ...
: V_CPU_CORES: [0]
I think this part should be dropped.
--
To view, visit http://gerrit.cloudera.org:8080/8865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
Gerrit-Change-Number: 8865
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Jan 2018 10:19:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8865
to look at the new patch set (#3).
Change subject: IMPALA-2181: [DOCS] Document changes to SET output
......................................................................
IMPALA-2181: [DOCS] Document changes to SET output
Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
---
M docs/topics/impala_set.xml
1 file changed, 77 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/8865/3
--
To view, visit http://gerrit.cloudera.org:8080/8865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
Gerrit-Change-Number: 8865
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8865
to look at the new patch set (#2).
Change subject: IMPALA-2181: [DOCS] Document changes to SET output
......................................................................
IMPALA-2181: [DOCS] Document changes to SET output
Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
---
M docs/topics/impala_set.xml
1 file changed, 75 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/8865/2
--
To view, visit http://gerrit.cloudera.org:8080/8865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
Gerrit-Change-Number: 8865
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8865 )
Change subject: IMPALA-2181: [DOCS] Document changes to SET output
......................................................................
IMPALA-2181: [DOCS] Document changes to SET output
Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
Reviewed-on: http://gerrit.cloudera.org:8080/8865
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_set.xml
1 file changed, 78 insertions(+), 9 deletions(-)
Approvals:
John Russell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
Gerrit-Change-Number: 8865
Gerrit-PatchSet: 5
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 )
Change subject: IMPALA-2181: [DOCS] Document changes to SET output
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8865/1/docs/topics/impala_set.xml
File docs/topics/impala_set.xml:
http://gerrit.cloudera.org:8080/#/c/8865/1/docs/topics/impala_set.xml@60
PS1, Line 60: Regular Query
> You can call these "Regular query options"
Done
http://gerrit.cloudera.org:8080/#/c/8865/1/docs/topics/impala_set.xml@90
PS1, Line 90: JDBC or ODBC
> On these interfaces besides adding the 'level' column, this "SET" vs "SET A
Done
--
To view, visit http://gerrit.cloudera.org:8080/8865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
Gerrit-Change-Number: 8865
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Jan 2018 05:48:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 )
Change subject: IMPALA-2181: [DOCS] Document changes to SET output
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Thanks John for the changes! Looks good to me.
http://gerrit.cloudera.org:8080/#/c/8865/3/docs/topics/impala_set.xml
File docs/topics/impala_set.xml:
http://gerrit.cloudera.org:8080/#/c/8865/3/docs/topics/impala_set.xml@54
PS3, Line 54: In <keyword keyref="impala211_full"/> and higher, the output of the <codeph>SET</codeph>
nit: I'm not sure how you treat trailing spaces in docs. Would you mind dropping them here?
--
To view, visit http://gerrit.cloudera.org:8080/8865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
Gerrit-Change-Number: 8865
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 11:18:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 )
Change subject: IMPALA-2181: [DOCS] Document changes to SET output
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
Gerrit-Change-Number: 8865
Gerrit-PatchSet: 4
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 20:11:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 )
Change subject: IMPALA-2181: [DOCS] Document changes to SET output
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/187/
--
To view, visit http://gerrit.cloudera.org:8080/8865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
Gerrit-Change-Number: 8865
Gerrit-PatchSet: 4
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 20:01:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 )
Change subject: IMPALA-2181: [DOCS] Document changes to SET output
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
Carrying forward +2 after minor update.
http://gerrit.cloudera.org:8080/#/c/8865/3/docs/topics/impala_set.xml
File docs/topics/impala_set.xml:
http://gerrit.cloudera.org:8080/#/c/8865/3/docs/topics/impala_set.xml@54
PS3, Line 54: In <keyword keyref="impala211_full"/> and higher, the output of the <codeph>SET</codeph>
> nit: I'm not sure how you treat trailing spaces in docs. Would you mind dro
Done
http://gerrit.cloudera.org:8080/#/c/8865/3/docs/topics/impala_set.xml@69
PS3, Line 69: related to internal development of Impala or features that are not yet finalized;
> Is it worth explicitly saying something like "Development query options may
Done
--
To view, visit http://gerrit.cloudera.org:8080/8865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
Gerrit-Change-Number: 8865
Gerrit-PatchSet: 4
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 20:00:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8865
to look at the new patch set (#4).
Change subject: IMPALA-2181: [DOCS] Document changes to SET output
......................................................................
IMPALA-2181: [DOCS] Document changes to SET output
Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
---
M docs/topics/impala_set.xml
1 file changed, 78 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/8865/4
--
To view, visit http://gerrit.cloudera.org:8080/8865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
Gerrit-Change-Number: 8865
Gerrit-PatchSet: 4
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 )
Change subject: IMPALA-2181: [DOCS] Document changes to SET output
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8865/1/docs/topics/impala_set.xml
File docs/topics/impala_set.xml:
http://gerrit.cloudera.org:8080/#/c/8865/1/docs/topics/impala_set.xml@60
PS1, Line 60: Query Options
You can call these "Regular query options"
http://gerrit.cloudera.org:8080/#/c/8865/1/docs/topics/impala_set.xml@90
PS1, Line 90: JDBC or ODBC
On these interfaces besides adding the 'level' column, this "SET" vs "SET ALL" distinction is also present meaning that "SET" all returns the regular and advanced options only, while "SET ALL" return all option groups.
--
To view, visit http://gerrit.cloudera.org:8080/8865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
Gerrit-Change-Number: 8865
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Dec 2017 14:25:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 )
Change subject: IMPALA-2181: [DOCS] Document changes to SET output
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Looks good, just had one optional suggestion
http://gerrit.cloudera.org:8080/#/c/8865/3/docs/topics/impala_set.xml
File docs/topics/impala_set.xml:
http://gerrit.cloudera.org:8080/#/c/8865/3/docs/topics/impala_set.xml@69
PS3, Line 69: related to internal development of Impala or features that are not yet finalized.
Is it worth explicitly saying something like "Development query options may be modified or removed without notice."
--
To view, visit http://gerrit.cloudera.org:8080/8865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
Gerrit-Change-Number: 8865
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 16:08:17 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-2181: [DOCS] Document changes to SET output
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8865 )
Change subject: IMPALA-2181: [DOCS] Document changes to SET output
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8865/2/docs/topics/impala_set.xml
File docs/topics/impala_set.xml:
http://gerrit.cloudera.org:8080/#/c/8865/2/docs/topics/impala_set.xml@214
PS2, Line 214: Shell Options
: LIVE_PROGRESS: False
: LIVE_SUMMARY: False
:
> I think this part should be dropped.
Done. Also there were a couple of references to "SET with no arguments" where I introduced the ALL keyword.
--
To view, visit http://gerrit.cloudera.org:8080/8865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iade7cb326715ebbb8518230d518d05601d615f61
Gerrit-Change-Number: 8865
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Jan 2018 04:45:55 +0000
Gerrit-HasComments: Yes