You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/02 08:10:58 UTC

[GitHub] [pulsar] mattisonchao edited a comment on pull request #14367: [Broker] Fix Broker HealthCheck Endpoint Exposes Race Conditions

mattisonchao edited a comment on pull request #14367:
URL: https://github.com/apache/pulsar/pull/14367#issuecomment-1056510784


   @eolivelli 
   Yes, I agree with you.
   
   I think we can avoid making this approach more complicated by removing the "cleanup" process after using ``Completable#handle`` to ensure we always close the reader/producer.
   
   But I think the subscription still needs to be rechecked, as reader shutdown can fail due to a number of factors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org