You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/11 16:59:09 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #28802: [SPARK-31950][SQL][TESTS] Extract SQL keywords from the SqlBase.g4 file

cloud-fan commented on a change in pull request #28802:
URL: https://github.com/apache/spark/pull/28802#discussion_r438934371



##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1197,6 +1199,7 @@ ansiNonReserved
 // The non-reserved keywords are listed in `nonReserved`.
 // These 2 together contain all the keywords.
 strictNonReserved
+//--ANSI-STRICT-NON-RESERVED-START

Review comment:
       this is not ansi, we should just call it `STRICT-NON-RESERVED`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org