You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Kiran Gawde (JIRA)" <ji...@apache.org> on 2011/09/13 02:43:10 UTC
[jira] [Created] (OFBIZ-4410) breadcrumbs.ftl code is not efficient
breadcrumbs.ftl code is not efficient
-------------------------------------
Key: OFBIZ-4410
URL: https://issues.apache.org/jira/browse/OFBIZ-4410
Project: OFBiz
Issue Type: Improvement
Components: order
Affects Versions: Release Branch 10.04
Reporter: Kiran Gawde
Priority: Minor
breadcrumbs.ftl recuses all the categories to show the correct breadcrumbs. Instead it should iterate over values from trail.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4410) breadcrumbs.ftl code is not efficient
Posted by "Kiran Gawde (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kiran Gawde updated OFBIZ-4410:
-------------------------------
Attachment: OFBIZ-4410-breadcrumbsEfficientCode.patch
Updated the patch to work with trunk
> breadcrumbs.ftl code is not efficient
> -------------------------------------
>
> Key: OFBIZ-4410
> URL: https://issues.apache.org/jira/browse/OFBIZ-4410
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: Release Branch 10.04
> Reporter: Kiran Gawde
> Priority: Minor
> Attachments: OFBIZ-4410-breadcrumbsEfficientCode.patch, OFBIZ-4410-breadcrumbsEfficientCode.patch
>
>
> breadcrumbs.ftl recuses all the categories to show the correct breadcrumbs. Instead it should iterate over values from trail.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4410) breadcrumbs.ftl code is not
efficient
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107414#comment-13107414 ]
Jacques Le Roux commented on OFBIZ-4410:
----------------------------------------
We don't apply improvements to releases, only bug fixes. Would this apply to trunk?
> breadcrumbs.ftl code is not efficient
> -------------------------------------
>
> Key: OFBIZ-4410
> URL: https://issues.apache.org/jira/browse/OFBIZ-4410
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: Release Branch 10.04
> Reporter: Kiran Gawde
> Priority: Minor
> Attachments: OFBIZ-4410-breadcrumbsEfficientCode.patch
>
>
> breadcrumbs.ftl recuses all the categories to show the correct breadcrumbs. Instead it should iterate over values from trail.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4410) breadcrumbs.ftl code is not efficient
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-4410.
----------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Assignee: Jacques Le Roux
Thanks Kiran,
Your patch is in trunk at r1175127
Just a little remark: when you provide a patch from Eclipse (using Subclipse), please follow [these recommendations|https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices#OFBizContributorsBestPractices-HowtoSendinYourContributions(orhowtocreateandapplypatches)] : "Eclipse internal command (don't use finish but rather select project to avoid the 2 1st lines in the patch)", ie
{code}
### Eclipse Workspace Patch 1.0
#P ofbiz-trunk
{code}
Else when applying from eclipse we get a project conflict. Not a big deal, but faster for us ;)
BTW at r1175130, I have also fixed a bug introduced at r737506, for a better formatting of breadcrumbs
> breadcrumbs.ftl code is not efficient
> -------------------------------------
>
> Key: OFBIZ-4410
> URL: https://issues.apache.org/jira/browse/OFBIZ-4410
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: Release Branch 10.04
> Reporter: Kiran Gawde
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4410-breadcrumbsEfficientCode.patch, OFBIZ-4410-breadcrumbsEfficientCode.patch
>
>
> breadcrumbs.ftl recuses all the categories to show the correct breadcrumbs. Instead it should iterate over values from trail.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4410) breadcrumbs.ftl code is not efficient
Posted by "Kiran Gawde (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kiran Gawde updated OFBIZ-4410:
-------------------------------
Attachment: OFBIZ-4410-breadcrumbsEfficientCode.patch
Patch for issue
> breadcrumbs.ftl code is not efficient
> -------------------------------------
>
> Key: OFBIZ-4410
> URL: https://issues.apache.org/jira/browse/OFBIZ-4410
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: Release Branch 10.04
> Reporter: Kiran Gawde
> Priority: Minor
> Attachments: OFBIZ-4410-breadcrumbsEfficientCode.patch
>
>
> breadcrumbs.ftl recuses all the categories to show the correct breadcrumbs. Instead it should iterate over values from trail.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4410) breadcrumbs.ftl code is not
efficient
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107525#comment-13107525 ]
Jacques Le Roux commented on OFBIZ-4410:
----------------------------------------
This does not apply to trunk. Could you create a trunk patch?
> breadcrumbs.ftl code is not efficient
> -------------------------------------
>
> Key: OFBIZ-4410
> URL: https://issues.apache.org/jira/browse/OFBIZ-4410
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: Release Branch 10.04
> Reporter: Kiran Gawde
> Priority: Minor
> Attachments: OFBIZ-4410-breadcrumbsEfficientCode.patch
>
>
> breadcrumbs.ftl recuses all the categories to show the correct breadcrumbs. Instead it should iterate over values from trail.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4410) breadcrumbs.ftl code is not
efficient
Posted by "Kiran Gawde (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107494#comment-13107494 ]
Kiran Gawde commented on OFBIZ-4410:
------------------------------------
No problem. Please apply this to trunk.
Regards,
Kiran Gawde
Senior Software Architect
Object Edge Inc
(925) 943 5558 x108
"There are two kind of people: Those who do the work and those who take
the credit. Try to be in the first group because there is less competition
there."
"Never give up on what you really want to do. The person with big dreams
is more powerful than one with all the facts".
From: "Jacques Le Roux (JIRA)" <ji...@apache.org>
To: kiran@objectedge.com
Date: 09/18/2011 04:06 AM
Subject: [jira] [Commented] (OFBIZ-4410) breadcrumbs.ftl code is
not efficient
[
https://issues.apache.org/jira/browse/OFBIZ-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107414#comment-13107414
]
Jacques Le Roux commented on OFBIZ-4410:
----------------------------------------
We don't apply improvements to releases, only bug fixes. Would this apply
to trunk?
breadcrumbs. Instead it should iterate over values from trail.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
> breadcrumbs.ftl code is not efficient
> -------------------------------------
>
> Key: OFBIZ-4410
> URL: https://issues.apache.org/jira/browse/OFBIZ-4410
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: Release Branch 10.04
> Reporter: Kiran Gawde
> Priority: Minor
> Attachments: OFBIZ-4410-breadcrumbsEfficientCode.patch
>
>
> breadcrumbs.ftl recuses all the categories to show the correct breadcrumbs. Instead it should iterate over values from trail.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira