You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by ch...@huawei.com on 2011/10/21 19:09:08 UTC

Re: Review Request: HIVE-1975 : "insert overwrite directory" Not able to insert data with multi level directory path

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1829/
-----------------------------------------------------------

(Updated 2011-10-21 17:09:08.230077)


Review request for hive and Yongqiang He.


Changes
-------

Reworked on the comments


Summary
-------

If insert into multilevel directory like '/HIVEFT25686/chinna/'
 (insert overwrite directory '/HIVEFT25686/chinna/' select * from dept_j) is failing because "fs.rename(sourcePath, targetPath)" is failing rename to multilevel directories, so first created the target path.


This addresses bug HIVE-1975.
    https://issues.apache.org/jira/browse/HIVE-1975


Diffs (updated)
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 1186875 

Diff: https://reviews.apache.org/r/1829/diff


Testing
-------

Ran all testcases


Thanks,

chinna


Re: Review Request: HIVE-1975 : "insert overwrite directory" Not able to insert data with multi level directory path

Posted by ch...@huawei.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1829/
-----------------------------------------------------------

(Updated 2011-10-28 13:53:07.086932)


Review request for hive and Yongqiang He.


Changes
-------

Addressed  Namit & He Yongqiang comments


Summary
-------

If insert into multilevel directory like '/HIVEFT25686/chinna/'
 (insert overwrite directory '/HIVEFT25686/chinna/' select * from dept_j) is failing because "fs.rename(sourcePath, targetPath)" is failing rename to multilevel directories, so first created the target path.


This addresses bug HIVE-1975.
    https://issues.apache.org/jira/browse/HIVE-1975


Diffs (updated)
-----

  trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1190202 
  trunk/conf/hive-default.xml 1190202 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 1190202 
  trunk/ql/src/test/queries/clientpositive/input45.q PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/input45.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1829/diff


Testing
-------

Ran all testcases


Thanks,

chinna