[jira] [Updated] (HIVE-16926) LlapTaskUmbilicalExternalClient should not start new umbilical server for every fragment request

["Jason Dere (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-16926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Dere updated HIVE-16926:
------------------------------
    Attachment: HIVE-16926.1.patch

Initial patch, restructured the LlapTaskUmbilicalExternalClient code a bit.
- Uses shared LLAP umbilical server rather than a new server per external client
- Retries rejected submissions (WorkSubmitter helper class)
- No more deferred cleanup (from HIVE-16652). One thing about this is that once clients are closed/unregistered, communicator.stop() is called and it's removed from the registered list of clients. So we might get a few warning messages about untracked taskAttemptIds coming in during heartbeat() .. if this is undesirable we might be able to leave them in the registeredClients list (but ignore heartbeats to them as they are tagged as closed), and remove them using the HeartbeatCheckTask once they get too old.

> LlapTaskUmbilicalExternalClient should not start new umbilical server for every fragment request
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-16926
>                 URL: https://issues.apache.org/jira/browse/HIVE-16926
>             Project: Hive
>          Issue Type: Sub-task
>          Components: llap
>            Reporter: Jason Dere
>            Assignee: Jason Dere
>         Attachments: HIVE-16926.1.patch
>
>
> Followup task from [~sseth] and [~sershe] after HIVE-16777.
> LlapTaskUmbilicalExternalClient currently creates a new umbilical server for every fragment request, but this is not necessary and the umbilical can be shared.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)