You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Shelley B (JIRA)" <ji...@codehaus.org> on 2007/11/05 19:45:35 UTC
[jira] Created: (MECLIPSE-339) Add facet version configuration
parameters
Add facet version configuration parameters
------------------------------------------
Key: MECLIPSE-339
URL: http://jira.codehaus.org/browse/MECLIPSE-339
Project: Maven 2.x Eclipse Plugin
Issue Type: Bug
Components: WTP support
Affects Versions: 2.4
Reporter: Shelley B
The maven-eclipse-plugin uses the declared dependencies within the POM to determine the facet versions in an EAR project, however, there may be a better approach.
The JEE jar is rarely, if ever, actually required by the EAR since it is provided by the container. Requiring an unnecessary dependency to be configured for the project, only to satisfy the maven-eclipse-plugin's configuration seems to violate Maven's principle of separation of concerns. (Further, due to licensing, the j2ee jars are not available in the central repository, so an install of this jar may be required just to allow for successful execution of the maven-eclipse-plugin.) If these jars are already declared in the POM, it makes sense to take advantage of them (to minimize configuration), however, in most cases, when the JEE jar is not a true dependency, it seems like an invalid workaround for determining the project facets in an EAR.
Adding an "earVersion" configuration parameter, or simply allowing project facets to be configured (overridden) in configuration might be a better approach. (Currently, the maven-eclipse-plugin allows "additionalProjectFacets" but does not allow the versions to be overridden.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-339) Add facet version configuration
parameters
Posted by "Shelley B (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_112872 ]
Shelley B commented on MECLIPSE-339:
------------------------------------
It looks like there already are some dependencies between the maven-eclipse-plugin and other plugin configuration. For example, the resolution for MECLIPSE-213 involves dependencies on the maven-ear-plugin configuration. If some tight coupling is allowed and is already used between the maven-eclipse-plugin and maven-ear-plugin, probably the most logical resolution for this issue is to simply read the ear version from the maven-ear-plugin if it exists. The ear facet version may be determined in the following order: (1) maven-eclipse-plugin jst.ear facet configuration (2) maven-ear-plugin version parameter, (3) j2ee dependency version.
> Add facet version configuration parameters
> ------------------------------------------
>
> Key: MECLIPSE-339
> URL: http://jira.codehaus.org/browse/MECLIPSE-339
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.4
> Reporter: Shelley B
>
> The maven-eclipse-plugin uses the declared dependencies within the POM to determine the facet versions in an EAR project, however, there may be a better approach.
> The JEE jar is rarely, if ever, actually required by the EAR since it is provided by the container. Requiring an unnecessary dependency to be configured for the project, only to satisfy the maven-eclipse-plugin's configuration seems to violate Maven's principle of separation of concerns. (Further, due to licensing, the j2ee jars are not available in the central repository, so an install of this jar may be required just to allow for successful execution of the maven-eclipse-plugin.) If these jars are already declared in the POM, it makes sense to take advantage of them (to minimize configuration), however, in most cases, when the JEE jar is not a true dependency, it seems like an invalid workaround for determining the project facets in an EAR.
> Adding an "earVersion" configuration parameter, or simply allowing project facets to be configured (overridden) in configuration might be a better approach. (Currently, the maven-eclipse-plugin allows "additionalProjectFacets" but does not allow the versions to be overridden.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira