[REMINDER] VelocityXSLTLayout

[Roall Lein-Killi <ro...@griffel.no>]

Hello turbinaries

A while ago I posted a contribution and nowbody
with cvs write access has commited the code nor
did it get criticism.

I really would like to see that code in tdk 1.1a12.

I know that XSLT not is optimal for high trafic sites
but I is useful in many cases. So it would be nice
to have a solution where the template developer 
easily could decide whether to write html or xml.
(And I am NOT proposing to make it the default layout)

If there is any confusion around the idea of VelocityXSLTLayout
don't hesitate do ask me post a better explanation.

Have any of you looked (or will look) at the code? 

Alternative: Give me cvs write access and I will use it with care
and after agreement with you.

regards killi 

-- 
Penguins are nice animals -
if you get to know them!

---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org

Re: [REMINDER] VelocityXSLTLayout

[Eric J Altman <ea...@speakeasy.org>]

Roall Lein-Killi wrote:
> 
> Hello turbinaries
> 
> A while ago I posted a contribution and nowbody
> with cvs write access has commited the code nor
> did it get criticism.

Hi,

I don't have cvs write, but I looked at your layout class briefly now
that you reminded us.  Looks like a good approach to layout with xslt. 
Did not build & test it out yet, though.  The lack of a cvs commit of
your class is probably just indicative of how busy Leon (defacto
maintainer of the xslt stuff) is in real life.  Or perhaps the folks who
use the xslt service have already written their own xslt layout(s) so
they don't have an itch to try something else.

In my case, I always just extend one of the existing basic layouts on a
per application basis, so no matter how good your implementation is I
can't really use it.  I typically don't allow the designer to define
what transform is used, instead employing a mapping in a prefs file or
other means like client sniffage to grab the right transform.  Don't
know if that's a particularly good methodology, but it works for me and
is very simple to admin.

If I have time to test it out I'll post further comments.  Perhaps you
could also test the small xslt service xalan-2.0.0 compatibility patch I
posted a while back.  Leon was getting some xpath exceptions so it's not
in cvs yet afaik.

Regards,
~Eric

-- 
Eric J Altman

---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org

Re: [REMINDER] VelocityXSLTLayout

[Roall Lein-Killi <ro...@griffel.no>]

Killi wrote:
>>�Hello turbinaries
�
>>�A while ago I posted a contribution and nowbody
>>�with cvs write access has commited the code nor
>>�did it get criticism.
>>�
>>�I really would like to see that code in tdk 1.1a12.
>>�
>�>I know that XSLT not is optimal for high trafic sites
>>�but I is useful in many cases. So it would be nice
>>�to have a solution where the template developer
>>�easily could decide whether to write html or xml.
>>(And I am NOT proposing to make it the default layout)
>>
>>�If there is any confusion around the idea of VelocityXSLTLayout
>>�don't hesitate do ask me post a better explanation.
>>�
>>�Have any of you looked (or will look) at the code?
>>
>>�Alternative: Give me cvs write access and I will use it with care
>>�and after agreement with you.
>>�
>>�regards killi 

Jon wrote:
> Ok, I *finally* got a chance to look at these classes and here are my
> comments:
>
> #0. It is a good start.

	thanks

> #1. The TemplateLayout should be a Tool and integrated via the PullService
> API's.

	I'dont agree. I belive that TemplateLayout and NavigationLayout is kind of
	alike ($navigation.setTemplate() and $layout.setStylesheet()). 
	
	I know that the user wouldn't see any difference if the names in the context
	are the same but I speak as a developer. 
	For me it's more intuitive this way.  

	If we are looking at TemplateLayout as a tool then its a
	communication/message tool (Hey brushtool tell the brush to use blue paint-)
	For me tools do something more. 

	Maybe I'm wrong. If I am, this is just thoughts and not important anyway.

> #2. The code that you gave me didn't even compile. 
	
	I'm sorry. It shouldn't happen and it want happen again.

>It was missing an import

	I known and I've postend a replay about that. 

> and was also missing a ";" at the end of one of the imports.

	That one I overlooked.
	
> If you make the #1 change, I will be happy to check the code into CVS.

	If thats what it takes. But it's not my idea and I don't look at it as a tool
	so you have to tell me it's name and where to live (package).

	And by the way: To become a tool it just has to implement 
	org.apache.turbine.services.pull.ApplicationTool. Right?

> thanks,
>
> -jon
>
>


regards
killi

-- 
Penguins are nice animals -
if you get to know them!

---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org

Re: [REMINDER] VelocityXSLTLayout

[Jon Stevens <jo...@latchkey.com>]

on 3/15/01 7:40 AM, "Roall Lein-Killi" <ro...@griffel.no> wrote:

> Hello turbinaries
> 
> A while ago I posted a contribution and nowbody
> with cvs write access has commited the code nor
> did it get criticism.
> 
> I really would like to see that code in tdk 1.1a12.
> 
> I know that XSLT not is optimal for high trafic sites
> but I is useful in many cases. So it would be nice
> to have a solution where the template developer
> easily could decide whether to write html or xml.
> (And I am NOT proposing to make it the default layout)
> 
> If there is any confusion around the idea of VelocityXSLTLayout
> don't hesitate do ask me post a better explanation.
> 
> Have any of you looked (or will look) at the code?
> 
> Alternative: Give me cvs write access and I will use it with care
> and after agreement with you.
> 
> regards killi 

Ok, I *finally* got a chance to look at these classes and here are my
comments:

#0. It is a good start.

#1. The TemplateLayout should be a Tool and integrated via the PullService
API's.

#2. The code that you gave me didn't even compile. It was missing an import
and was also missing a ";" at the end of one of the imports.

If you make the #1 change, I will be happy to check the code into CVS.

thanks,

-jon


---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org