You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by justin-mcdavid-ibm <gi...@git.apache.org> on 2017/03/28 18:48:06 UTC
[GitHub] couchdb-fauxton pull request #892: Continued styles and text tidying
GitHub user justin-mcdavid-ibm opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/892
Continued styles and text tidying
I've edited strings for clarity/consistency in a number of places.
Updated primary/secondary-action buttons to be consistently styled.
Added hover states to a number of buttons that didn't previously have them.
Made some minor style changes (rule colors, heading spacing)
Removed underline effects on links, but maintained hover-color and cursor changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/justin-mcdavid-ibm/couchdb-fauxton colorclysm-cleanup-couch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/892.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #892
----
commit fc40711f42cad8797eafc6b9070657d2e9d18523
Author: Justin McDavid <jm...@us.ibm.com>
Date: 2017-03-27T21:03:36Z
WIP for continuing styles work
commit f25eae14e9af85e341557699e60fa839d4423f28
Author: Justin McDavid <jm...@us.ibm.com>
Date: 2017-03-27T23:02:02Z
WIP Continued Text and style tweaks
commit f4c744444db48f457be373d05ee0fdb1468f5158
Author: Justin McDavid <jm...@us.ibm.com>
Date: 2017-03-28T01:47:02Z
WIP more small tweaks.
commit 1bf492ffe905cd0ffbf939f12c82d59387d0e60a
Author: Justin McDavid <jm...@us.ibm.com>
Date: 2017-03-28T18:33:09Z
More styles/text work.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #892: Continued styles and text tidying
Posted by millayr <gi...@git.apache.org>.
Github user millayr commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/892
I noticed that hovering over database names on the `_all_dbs` page doesn't change the link text color. Is that your intent?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #892: Continued styles and text tidying
Posted by justin-mcdavid-ibm <gi...@git.apache.org>.
Github user justin-mcdavid-ibm commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/892#discussion_r108730551
--- Diff: assets/less/templates.less ---
@@ -177,13 +177,12 @@
font-weight: normal;
font-family: helvetica;
.box-sizing(border-box);
- background-color: #564E4C;
+ background-color: @brandDark1
--- End diff --
fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #892: Continued styles and text tidying
Posted by millayr <gi...@git.apache.org>.
Github user millayr commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/892#discussion_r108672812
--- Diff: assets/less/formstyles.less ---
@@ -78,25 +78,52 @@ button:focus {
}
}
}
-.btn-primary {
- background: #2bb673;
- color: #fff;
-}
-.btn.btn-danger {
- background-color: #f00;
- color: #fff;
+.btn-primary, .btn-success {
+ color: @buttonText;
+ background-color: @primaryGreen;
+ border-color: @primaryGreen;
+ &:disabled, &[disabled]:hover {
+ background-color: @primaryGreenDisabled;
+ border-color: @primaryGreenDisabled;
+ color: @buttonTextDisabled;
+ }
}
+
.btn-secondary {
- background-color: #0082BF;
- color: #fff;
+ color: @buttonText;
+ background-color: @secondaryBlue;
+ border-color: @secondaryBlue;
+ &:disabled, &[disabled] {
+ color: @buttonTextDisabled;
+ background-color: @secondaryBlueDisabled;
+ border-color: @secondaryBlueDisabled;
+ }
+}
+
+.btn-tertiary {
+ color: @secondaryBlue;
+ background-color: @buttonText;
+ border: 2px solid @secondaryBlue;
+ &:disabled, &[disabled] {
--- End diff --
same as above
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #892: Continued styles and text tidying
Posted by millayr <gi...@git.apache.org>.
Github user millayr commented on the issue:
https://github.com/apache/couchdb-fauxton/pull/892
Looks like you're reintroducing the bug fixed in https://github.com/apache/couchdb-fauxton/pull/891. You might want to consider rebasing this branch onto master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #892: Continued styles and text tidying
Posted by justin-mcdavid-ibm <gi...@git.apache.org>.
Github user justin-mcdavid-ibm commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/892#discussion_r108730569
--- Diff: assets/less/formstyles.less ---
@@ -78,25 +78,52 @@ button:focus {
}
}
}
-.btn-primary {
- background: #2bb673;
- color: #fff;
-}
-.btn.btn-danger {
- background-color: #f00;
- color: #fff;
+.btn-primary, .btn-success {
+ color: @buttonText;
+ background-color: @primaryGreen;
+ border-color: @primaryGreen;
+ &:disabled, &[disabled]:hover {
+ background-color: @primaryGreenDisabled;
+ border-color: @primaryGreenDisabled;
+ color: @buttonTextDisabled;
+ }
}
+
.btn-secondary {
- background-color: #0082BF;
- color: #fff;
+ color: @buttonText;
+ background-color: @secondaryBlue;
+ border-color: @secondaryBlue;
+ &:disabled, &[disabled] {
+ color: @buttonTextDisabled;
+ background-color: @secondaryBlueDisabled;
+ border-color: @secondaryBlueDisabled;
+ }
+}
+
+.btn-tertiary {
+ color: @secondaryBlue;
+ background-color: @buttonText;
+ border: 2px solid @secondaryBlue;
+ &:disabled, &[disabled] {
--- End diff --
fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #892: Continued styles and text tidying
Posted by millayr <gi...@git.apache.org>.
Github user millayr commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/892#discussion_r108674467
--- Diff: assets/less/templates.less ---
@@ -177,13 +177,12 @@
font-weight: normal;
font-family: helvetica;
.box-sizing(border-box);
- background-color: #564E4C;
+ background-color: @brandDark1
--- End diff --
needs a semi colon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #892: Continued styles and text tidying
Posted by justin-mcdavid-ibm <gi...@git.apache.org>.
Github user justin-mcdavid-ibm commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/892#discussion_r108730599
--- Diff: assets/less/formstyles.less ---
@@ -78,25 +78,52 @@ button:focus {
}
}
}
-.btn-primary {
- background: #2bb673;
- color: #fff;
-}
-.btn.btn-danger {
- background-color: #f00;
- color: #fff;
+.btn-primary, .btn-success {
+ color: @buttonText;
+ background-color: @primaryGreen;
+ border-color: @primaryGreen;
+ &:disabled, &[disabled]:hover {
--- End diff --
fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #892: Continued styles and text tidying
Posted by justin-mcdavid-ibm <gi...@git.apache.org>.
Github user justin-mcdavid-ibm commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/892#discussion_r108730538
--- Diff: assets/less/formstyles.less ---
@@ -78,25 +78,52 @@ button:focus {
}
}
}
-.btn-primary {
- background: #2bb673;
- color: #fff;
-}
-.btn.btn-danger {
- background-color: #f00;
- color: #fff;
+.btn-primary, .btn-success {
+ color: @buttonText;
+ background-color: @primaryGreen;
+ border-color: @primaryGreen;
+ &:disabled, &[disabled]:hover {
+ background-color: @primaryGreenDisabled;
+ border-color: @primaryGreenDisabled;
+ color: @buttonTextDisabled;
+ }
}
+
.btn-secondary {
- background-color: #0082BF;
- color: #fff;
+ color: @buttonText;
+ background-color: @secondaryBlue;
+ border-color: @secondaryBlue;
+ &:disabled, &[disabled] {
+ color: @buttonTextDisabled;
+ background-color: @secondaryBlueDisabled;
+ border-color: @secondaryBlueDisabled;
+ }
+}
+
+.btn-tertiary {
+ color: @secondaryBlue;
+ background-color: @buttonText;
+ border: 2px solid @secondaryBlue;
+ &:disabled, &[disabled] {
+ color: @secondaryBlueDisabled;
+ background-color: @primaryGreenDisabled;
+ border-color: @buttonTextDisabled;
+ }
}
-.btn-primary:hover, .btn-secondary:hover, .btn-danger:hover, {
+
+.btn-success:hover, .btn-primary:hover, .btn-secondary:hover, .btn-tertiary:hover, .btn-warning:hover, .btn-danger:hover {
background-color: @hoverHighlight;
- color: #fff;
}
-.btn-primary a:visited {
- color: #fff;
+.btn-warning, .btn-danger {
+ color: @buttonText;
+ background-color: @dangerRed;
+ border-color: @dangerRed;
+ &:disabled {
--- End diff --
fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #892: Continued styles and text tidying
Posted by millayr <gi...@git.apache.org>.
Github user millayr commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/892#discussion_r108672779
--- Diff: assets/less/formstyles.less ---
@@ -78,25 +78,52 @@ button:focus {
}
}
}
-.btn-primary {
- background: #2bb673;
- color: #fff;
-}
-.btn.btn-danger {
- background-color: #f00;
- color: #fff;
+.btn-primary, .btn-success {
+ color: @buttonText;
+ background-color: @primaryGreen;
+ border-color: @primaryGreen;
+ &:disabled, &[disabled]:hover {
+ background-color: @primaryGreenDisabled;
+ border-color: @primaryGreenDisabled;
+ color: @buttonTextDisabled;
+ }
}
+
.btn-secondary {
- background-color: #0082BF;
- color: #fff;
+ color: @buttonText;
+ background-color: @secondaryBlue;
+ border-color: @secondaryBlue;
+ &:disabled, &[disabled] {
--- End diff --
This looks a bit redundant without the `:hover`. Also consider my suggestion in the previous comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #892: Continued styles and text tidying
Posted by millayr <gi...@git.apache.org>.
Github user millayr commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/892#discussion_r108677355
--- Diff: assets/less/formstyles.less ---
@@ -78,25 +78,52 @@ button:focus {
}
}
}
-.btn-primary {
- background: #2bb673;
- color: #fff;
-}
-.btn.btn-danger {
- background-color: #f00;
- color: #fff;
+.btn-primary, .btn-success {
+ color: @buttonText;
+ background-color: @primaryGreen;
+ border-color: @primaryGreen;
+ &:disabled, &[disabled]:hover {
+ background-color: @primaryGreenDisabled;
+ border-color: @primaryGreenDisabled;
+ color: @buttonTextDisabled;
+ }
}
+
.btn-secondary {
- background-color: #0082BF;
- color: #fff;
+ color: @buttonText;
+ background-color: @secondaryBlue;
+ border-color: @secondaryBlue;
+ &:disabled, &[disabled] {
+ color: @buttonTextDisabled;
+ background-color: @secondaryBlueDisabled;
+ border-color: @secondaryBlueDisabled;
+ }
+}
+
+.btn-tertiary {
+ color: @secondaryBlue;
+ background-color: @buttonText;
+ border: 2px solid @secondaryBlue;
+ &:disabled, &[disabled] {
+ color: @secondaryBlueDisabled;
+ background-color: @primaryGreenDisabled;
+ border-color: @buttonTextDisabled;
+ }
}
-.btn-primary:hover, .btn-secondary:hover, .btn-danger:hover, {
+
+.btn-success:hover, .btn-primary:hover, .btn-secondary:hover, .btn-tertiary:hover, .btn-warning:hover, .btn-danger:hover {
background-color: @hoverHighlight;
- color: #fff;
}
-.btn-primary a:visited {
- color: #fff;
+.btn-warning, .btn-danger {
+ color: @buttonText;
+ background-color: @dangerRed;
+ border-color: @dangerRed;
+ &:disabled {
--- End diff --
no need to consider hover state here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #892: Continued styles and text tidying
Posted by justin-mcdavid-ibm <gi...@git.apache.org>.
Github user justin-mcdavid-ibm commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/892#discussion_r108730588
--- Diff: assets/less/formstyles.less ---
@@ -78,25 +78,52 @@ button:focus {
}
}
}
-.btn-primary {
- background: #2bb673;
- color: #fff;
-}
-.btn.btn-danger {
- background-color: #f00;
- color: #fff;
+.btn-primary, .btn-success {
+ color: @buttonText;
+ background-color: @primaryGreen;
+ border-color: @primaryGreen;
+ &:disabled, &[disabled]:hover {
+ background-color: @primaryGreenDisabled;
+ border-color: @primaryGreenDisabled;
+ color: @buttonTextDisabled;
+ }
}
+
.btn-secondary {
- background-color: #0082BF;
- color: #fff;
+ color: @buttonText;
+ background-color: @secondaryBlue;
+ border-color: @secondaryBlue;
+ &:disabled, &[disabled] {
--- End diff --
fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #892: Continued styles and text tidying
Posted by millayr <gi...@git.apache.org>.
Github user millayr commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/892#discussion_r108672638
--- Diff: assets/less/formstyles.less ---
@@ -78,25 +78,52 @@ button:focus {
}
}
}
-.btn-primary {
- background: #2bb673;
- color: #fff;
-}
-.btn.btn-danger {
- background-color: #f00;
- color: #fff;
+.btn-primary, .btn-success {
+ color: @buttonText;
+ background-color: @primaryGreen;
+ border-color: @primaryGreen;
+ &:disabled, &[disabled]:hover {
--- End diff --
Minor but my opinion is using `pointer-events: none;` instead of specifying `&[disabled]:hover` could be a bit cleaner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---