You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Jeff-Lv (GitHub)" <gi...@apache.org> on 2018/10/11 07:39:04 UTC
[GitHub] [incubator-dubbo] Jeff-Lv opened pull request #2636: [Dubbo]
move the classes of model from config to rpc-api for reusing
## What is the purpose of the change
reusing those model in rpc module.
## Brief changelog
the refactor is very safe with unit test convering.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2636 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2636:
[Dubbo] move the classes of model from config to rpc-api for reusing
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2636?src=pr&el=h1) Report
> Merging [#2636](https://codecov.io/gh/apache/incubator-dubbo/pull/2636?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/adb5b0e3ed2a785b83b5bb48b9fdb7e63fa5ae30?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `22.22%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2636?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2636 +/- ##
===========================================
- Coverage 55.05% 54.8% -0.25%
+ Complexity 5283 5263 -20
===========================================
Files 571 571
Lines 25515 25510 -5
Branches 4532 4532
===========================================
- Hits 14048 13982 -66
- Misses 9352 9419 +67
+ Partials 2115 2109 -6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2636?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/dubbo/rpc/model/ProviderMethodModel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2636/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9tb2RlbC9Qcm92aWRlck1ldGhvZE1vZGVsLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...a/org/apache/dubbo/rpc/model/ApplicationModel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2636/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9tb2RlbC9BcHBsaWNhdGlvbk1vZGVsLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...ava/org/apache/dubbo/qos/command/impl/Offline.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2636/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL2NvbW1hbmQvaW1wbC9PZmZsaW5lLmphdmE=) | `95.83% <ø> (ø)` | `7 <0> (ø)` | :arrow_down: |
| [...ain/java/org/apache/dubbo/qos/command/impl/Ls.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2636/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL2NvbW1hbmQvaW1wbC9Mcy5qYXZh) | `85% <ø> (ø)` | `9 <0> (ø)` | :arrow_down: |
| [...java/org/apache/dubbo/qos/command/impl/Online.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2636/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL2NvbW1hbmQvaW1wbC9PbmxpbmUuamF2YQ==) | `83.33% <ø> (ø)` | `5 <0> (ø)` | :arrow_down: |
| [...java/org/apache/dubbo/rpc/model/ProviderModel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2636/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9tb2RlbC9Qcm92aWRlck1vZGVsLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...rg/apache/dubbo/rpc/model/ConsumerMethodModel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2636/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9tb2RlbC9Db25zdW1lck1ldGhvZE1vZGVsLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...java/org/apache/dubbo/rpc/model/ConsumerModel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2636/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9tb2RlbC9Db25zdW1lck1vZGVsLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2636/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `51.07% <100%> (+0.35%)` | `42 <0> (ø)` | :arrow_down: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2636/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `47.9% <100%> (-0.47%)` | `63 <0> (-1)` | |
| ... and [12 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2636/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2636?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2636?src=pr&el=footer). Last update [adb5b0e...c78648a](https://codecov.io/gh/apache/incubator-dubbo/pull/2636?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2636 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] chickenlj closed pull request #2636:
[Dubbo] move the classes of model from config to rpc-api for reusing
Posted by "chickenlj (GitHub)" <gi...@apache.org>.
[ pull request closed by chickenlj ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2636 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] chickenlj commented on issue #2636:
[Dubbo] move the classes of model from config to rpc-api for reusing
Posted by "chickenlj (GitHub)" <gi...@apache.org>.
If it prevents reuse when staying in the config module, then let's move these classes to the rpc module.
This migration will have no effect on other functionalities but for telnet, please make sure telnet still works fine when doing this.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2636 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org