You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/01 08:07:34 UTC
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21881: Revise #11838, remove `EmptyStatement` from hint executor.
codecov-commenter commented on PR #21881:
URL: https://github.com/apache/shardingsphere/pull/21881#issuecomment-1298187637
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21881?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21881](https://codecov.io/gh/apache/shardingsphere/pull/21881?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b74bca) into [master](https://codecov.io/gh/apache/shardingsphere/commit/1c66cbbac3deb29a56259ce2e0c5ccbb5369d677?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c66cbb) will **increase** coverage by `0.03%`.
> The diff coverage is `30.00%`.
```diff
@@ Coverage Diff @@
## master #21881 +/- ##
============================================
+ Coverage 61.03% 61.07% +0.03%
+ Complexity 2454 2453 -1
============================================
Files 4110 4108 -2
Lines 57260 57204 -56
Branches 9673 9664 -9
============================================
- Hits 34950 34938 -12
+ Misses 19388 19346 -42
+ Partials 2922 2920 -2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...executor/AddShardingHintDatabaseValueExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/21881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZXhlY3V0b3IvQWRkU2hhcmRpbmdIaW50RGF0YWJhc2VWYWx1ZUV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nt/executor/AddShardingHintTableValueExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/21881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZXhlY3V0b3IvQWRkU2hhcmRpbmdIaW50VGFibGVWYWx1ZUV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...r/distsql/ral/hint/executor/ClearHintExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/21881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZXhlY3V0b3IvQ2xlYXJIaW50RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../executor/ClearReadwriteSplittingHintExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/21881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZXhlY3V0b3IvQ2xlYXJSZWFkd3JpdGVTcGxpdHRpbmdIaW50RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...l/ral/hint/executor/ClearShardingHintExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/21881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZXhlY3V0b3IvQ2xlYXJTaGFyZGluZ0hpbnRFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nt/executor/SetReadwriteSplittingHintExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/21881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZXhlY3V0b3IvU2V0UmVhZHdyaXRlU3BsaXR0aW5nSGludEV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...executor/SetShardingHintDatabaseValueExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/21881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZXhlY3V0b3IvU2V0U2hhcmRpbmdIaW50RGF0YWJhc2VWYWx1ZUV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...tsql/ral/hint/HintRALStatementExecutorFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/21881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvSGludFJBTFN0YXRlbWVudEV4ZWN1dG9yRmFjdG9yeS5qYXZh) | `89.47% <100.00%> (ø)` | |
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/21881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| [.../statement/rql/show/ShowStorageUnitsStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/21881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL3N0YXRlbWVudC9ycWwvc2hvdy9TaG93U3RvcmFnZVVuaXRzU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/shardingsphere/pull/21881/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org