You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@avro.apache.org by "Collin Scangarella (JIRA)" <ji...@apache.org> on 2018/03/14 04:40:00 UTC

[jira] [Comment Edited] (AVRO-435) Support Set containers

    [ https://issues.apache.org/jira/browse/AVRO-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397860#comment-16397860 ] 

Collin Scangarella edited comment on AVRO-435 at 3/14/18 4:39 AM:
------------------------------------------------------------------

Hey [~cutting] - thanks for the implementation info. I have included your recommendations in a patch. To sum up: SpecificCompiler::javaType returns java.util.Set if the useSet property is present. GenericDatumReader now has an inner class Set which extends Array. GenericDatumReader::newArray returns a GenericDatumReader.Set if the useSet property is present. There are tests for SpecificCompiler and GenericDatumReader but not for GenericDatumReader.Set (as it just extends GenericDatumReader.Array and doesn't enforce uniqueness per your comments). However, Jira won't let me attach a file to this comment. How can I submit it?


was (Author: cscangarella):
Hey [~cutting] - thanks for the implementation info. I have included your recommendations in a patch. To sum up: SpecificCompiler::javaType returns java.util.Set if the useSet property is present. GenericDatumReader now has an inner class Set which extends Array. GenericDatumReader::newArray returns a GenericDatumReader.Set if the useSet property is present. There are tests for SpecificCompiler and GenericDatumReader but not for GenericDatumReader.Set (as it just extends GenericDatumReader.Array and doesn't enforce uniqueness per your comments). However, Jira won't let me attach a file for this patch. How can I submit it?

> Support Set containers
> ----------------------
>
>                 Key: AVRO-435
>                 URL: https://issues.apache.org/jira/browse/AVRO-435
>             Project: Avro
>          Issue Type: New Feature
>          Components: spec
>            Reporter: Jonathan Ellis
>            Priority: Minor
>
> Cassandra uses Set as a return type for some methods.  It would be nice to not have to use a List as a workaround.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)