You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/22 12:19:14 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #39181: [SPARK-41647][CONNECT] Deduplicate docstrings in pyspark.sql.connect.functions
HyukjinKwon opened a new pull request, #39181:
URL: https://github.com/apache/spark/pull/39181
### What changes were proposed in this pull request?
This PR proposes to deduplicate docstrings in `pyspark.sql.connect.functions`.
### Why are the changes needed?
For easier maintenance
### Does this PR introduce _any_ user-facing change?
No, dev-only. There're mintor doc changes that mention about remote support in Apache Spark 3.4.
### How was this patch tested?
No test. It has to be manually verified until we resolve SPARK-41653.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #39181: [SPARK-41647][CONNECT] Deduplicate docstrings in pyspark.sql.connect.functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #39181:
URL: https://github.com/apache/spark/pull/39181#discussion_r1055402797
##########
python/pyspark/sql/functions.py:
##########
@@ -132,6 +132,9 @@ def lit(col: Any) -> Column:
Review Comment:
Missing functions in Spark Connect are:
```
window_time
call_udf
days
window
hours
pandas_udf
sequence
bucket
years
session_window
format_number
unwrap_udt
udf
months
```
FYI @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #39181: [SPARK-41647][CONNECT] Deduplicate docstrings in pyspark.sql.connect.functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #39181:
URL: https://github.com/apache/spark/pull/39181#discussion_r1056132676
##########
python/pyspark/sql/functions.py:
##########
@@ -132,6 +132,9 @@ def lit(col: Any) -> Column:
Review Comment:
thank you,
the `Partition Transformation Functions` is tracked in https://issues.apache.org/jira/browse/SPARK-41503
I will add udf-related function after udf is supported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39181: [SPARK-41647][CONNECT] Deduplicate docstrings in pyspark.sql.connect.functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39181: [SPARK-41647][CONNECT] Deduplicate docstrings in pyspark.sql.connect.functions
URL: https://github.com/apache/spark/pull/39181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39181: [SPARK-41647][CONNECT] Deduplicate docstrings in pyspark.sql.connect.functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39181:
URL: https://github.com/apache/spark/pull/39181#issuecomment-1363635588
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39181: [SPARK-41647][CONNECT] Deduplicate docstrings in pyspark.sql.connect.functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39181:
URL: https://github.com/apache/spark/pull/39181#issuecomment-1362774184
To make sure, I wrote a script and updated the codes. I also manually checked one by one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org