You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by lucky-chen <gi...@git.apache.org> on 2018/04/25 12:48:12 UTC

[GitHub] incubator-weex pull request #1129: [iOS] support more performance point

GitHub user lucky-chen opened a pull request:

    https://github.com/apache/incubator-weex/pull/1129

    [iOS] support more performance point

    * [iOS] support more performance point
    
     *isNewFeature* **:**
    
      * [ ] Update API docs for the component.
      * [ x] Update/Add demo to demonstrate new feature.
      * [ ] Update test scripts for the feature.
      * [ ] Add unit tests for the feature.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lucky-chen/incubator-weex ios-feature-gky-performance

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1129
    
----
commit 3d77c7bd0646b30fbfc0503e79a607ce0886d310
Author: zhongcang <qh...@...>
Date:   2018-03-28T05:25:07Z

    * [iOS] add analyzerFile
    
    * [iOS] support more performance point
    
    * [iOS] fix compile

----


---

[GitHub] incubator-weex pull request #1129: [WEEX-305][iOS] support more performance ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1129


---

[GitHub] incubator-weex pull request #1129: [WEEX-305][iOS] support more performance ...

Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/1129#discussion_r184259269
  
    --- Diff: ios/sdk/WeexSDK.xcodeproj/project.pbxproj ---
    @@ -8,6 +8,21 @@
     
     /* Begin PBXBuildFile section */
     		042013AD1E66CD6A001FC79C /* WXValidateProtocol.h in Headers */ = {isa = PBXBuildFile; fileRef = 042013AC1E66CD6A001FC79C /* WXValidateProtocol.h */; settings = {ATTRIBUTES = (Public, ); }; };
    +		170B4664208733AF00562666 /* WXAnalyzerCenter.h in Headers */ = {isa = PBXBuildFile; fileRef = 17C74F092072145000AB4CAB /* WXAnalyzerCenter.h */; settings = {ATTRIBUTES = (Public, ); }; };
    +		170B4665208733BF00562666 /* WXAnalyzerCenter+Transfer.h in Headers */ = {isa = PBXBuildFile; fileRef = 17C74F082072145000AB4CAB /* WXAnalyzerCenter+Transfer.h */; };
    +		170B4666208733D200562666 /* (null) in Sources */ = {isa = PBXBuildFile; };
    +		170B4667208733D800562666 /* (null) in Headers */ = {isa = PBXBuildFile; };
    --- End diff --
    
    what's `null `  in headers 


---

[GitHub] incubator-weex issue #1129: [iOS] support more performance point

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1129
  
    
    <!--
      0 failure: 
      0 warning: 
      2 messages
      
    -->
    
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>has no jsfm file changed.</td>
        </tr>
      
    <tr>
          <td>:book:</td>
          <td>jsfm test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---

[GitHub] incubator-weex pull request #1129: [WEEX-305][iOS] support more performance ...

Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on a diff in the pull request:

    https://github.com/apache/incubator-weex/pull/1129#discussion_r184260545
  
    --- Diff: ios/sdk/WeexSDK.xcodeproj/project.pbxproj ---
    @@ -2341,8 +2379,10 @@
     				DCA4456E1EFA55B300D0CFA8 /* WXModalUIModule.m in Sources */,
     				DCA4456F1EFA55B300D0CFA8 /* WXWebViewModule.m in Sources */,
     				DCA445701EFA55B300D0CFA8 /* WXCanvasModule.m in Sources */,
    +				170B4668208733E500562666 /* WXAnalyzerCenter.m in Sources */,
     				DCA445711EFA55B300D0CFA8 /* WXMetaModule.m in Sources */,
     				DCA445721EFA55B300D0CFA8 /* WXBoxShadow.m in Sources */,
    +				170B4666208733D200562666 /* (null) in Sources */,
    --- End diff --
    
    null ?


---