You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/13 20:29:32 UTC

[GitHub] mik-laj commented on a change in pull request #4064: AIRFLOW-3149 Support dataproc cluster deletion on ERROR

mik-laj commented on a change in pull request #4064: AIRFLOW-3149 Support dataproc cluster deletion on ERROR
URL: https://github.com/apache/airflow/pull/4064#discussion_r247361419
 
 

 ##########
 File path: airflow/contrib/operators/dataproc_operator.py
 ##########
 @@ -35,6 +35,31 @@
 from airflow.utils import timezone
 
 
+# Common code to share over operators.  Better way to do this?
+def _wait_for_delete_done(service, operation_name):
 
 Review comment:
   It's better to put this code in Hook.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services