You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2018/06/27 09:08:20 UTC

[GitHub] flink pull request #6213: [FLINK-9672] Fail fatally if job submission fails ...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/6213

    [FLINK-9672] Fail fatally if job submission fails on added JobGraph signal

    ## What is the purpose of the change
    
    Fail fatally if we cannot recover the job on the `onAddedJobGraph` signal from the `SubmittedJobGraphListener`.
    
    ## Verifying this change
    
    - Added `DispatcherTest#testOnAddedJobGraphRecoveryFailure` and `DispatcherTest#testOnAddedJobGraphWithFinishedJob`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink hardenOnAddedJobGraph

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6213
    
----
commit e60f2a2b0d9a8ffd5bca91418a1d0be5e24db77b
Author: Till Rohrmann <tr...@...>
Date:   2018-06-27T07:49:36Z

    [hotfix] Remove unnecessary logging in Dispatcher#listJobs

commit 2d5835fc3973d32ad174db5a1d80e02048bbd224
Author: Till Rohrmann <tr...@...>
Date:   2018-06-27T08:46:59Z

    [FLINK-9672] Fail fatally if job submission fails on added JobGraph signal

----


---

[GitHub] flink pull request #6213: [FLINK-9672] Fail fatally if job submission fails ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6213


---

[GitHub] flink issue #6213: [FLINK-9672] Fail fatally if job submission fails on adde...

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/6213
  
    Thanks for the review @GJL. Merging this PR into master and `release-1.5` branch.


---

[GitHub] flink pull request #6213: [FLINK-9672] Fail fatally if job submission fails ...

Posted by GJL <gi...@git.apache.org>.

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6213#discussion_r198912529
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java ---
    @@ -322,9 +322,6 @@ private JobManagerRunner createJobManagerRunner(JobGraph jobGraph) throws Except
     
     	@Override
     	public CompletableFuture<Collection<JobID>> listJobs(Time timeout) {
    -		if (jobManagerRunners.isEmpty()) {
    --- End diff --
    
    nice


---