You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/15 13:50:51 UTC
[GitHub] [camel] pmoerenhout opened a new pull request #5090: Change SMPP default enquireLinkTimer from 5 seconds to 60 seconds.
pmoerenhout opened a new pull request #5090:
URL: https://github.com/apache/camel/pull/5090
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
Change the default SMPP enquireLinkTime from 5 to 60 seconds. The default of 5 seconds is too aggressive for default connections not specifying an other value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #5090: Change SMPP default enquireLinkTimer from 5 seconds to 60 seconds.
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #5090:
URL: https://github.com/apache/camel/pull/5090#issuecomment-779239583
The sourcecheck is failing for another commit, the jira is not really needed, I was noticiing this because you marked the first point of PR template
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] pmoerenhout commented on pull request #5090: Change SMPP default enquireLinkTimer from 5 seconds to 60 seconds.
Posted by GitBox <gi...@apache.org>.
pmoerenhout commented on pull request #5090:
URL: https://github.com/apache/camel/pull/5090#issuecomment-779239107
I can create the Jira, no problem, I also see that the sourcecheck failed on the imports. Will redo the PR...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #5090: Change SMPP default enquireLinkTimer from 5 seconds to 60 seconds.
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #5090:
URL: https://github.com/apache/camel/pull/5090
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] PascalSchumacher commented on pull request #5090: Change SMPP default enquireLinkTimer from 5 seconds to 60 seconds.
Posted by GitBox <gi...@apache.org>.
PascalSchumacher commented on pull request #5090:
URL: https://github.com/apache/camel/pull/5090#issuecomment-779385084
+1, at work we also changed it to 60 seconds years ago, because the SMSC colleagues complained about the 5 second interval.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org