You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Michael McCandless <lu...@mikemccandless.com> on 2009/04/02 11:44:21 UTC
ant test should include test-tag
I think back-compat tests ("ant test-tag") should run when you run "ant test".
Any objections?
If not I'll commit soon...
Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: ant test should include test-tag
Posted by Michael McCandless <lu...@mikemccandless.com>.
OK I I just left that new one off. So you have to run "ant test-core
test-contrib".
Mike
On Thu, Apr 2, 2009 at 7:21 AM, Mark Miller <ma...@gmail.com> wrote:
> Wouldn't hurt I suppose - but test-core and test-contrib are probably
> sufficient. I wasn't very clear with that comment. I was just saying, as
> long as I can still run the tests a bit quicker than running through
> everything twice - which is already available. I should have just said +1.
> On the other hand, test-core-contrib doesn't hurt anything.
>
> Michael McCandless wrote:
>>
>> OK I'll add a "test-core-contrib" target.
>>
>> Mike
>>
>> On Thu, Apr 2, 2009 at 6:45 AM, Mark Miller <ma...@gmail.com> wrote:
>>
>>>
>>> Shai Erera wrote:
>>>
>>>>
>>>> I definitely agree. It would have saved me another patch submission in
>>>> 1575 :)
>>>>
>>>> On Thu, Apr 2, 2009 at 12:44 PM, Michael McCandless
>>>> <lucene@mikemccandless.com <ma...@mikemccandless.com>> wrote:
>>>>
>>>> I think back-compat tests ("ant test-tag") should run when you run
>>>> "ant test".
>>>>
>>>> Any objections?
>>>>
>>>> If not I'll commit soon...
>>>>
>>>> Mike
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>>> <ma...@lucene.apache.org>
>>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>> <ma...@lucene.apache.org>
>>>>
>>>>
>>>>
>>>
>>> As long as I still have a target that will test without back compat
>>> tests.
>>>
>>> --
>>> - Mark
>>>
>>> http://www.lucidimagination.com
>>>
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>>
>
>
> --
> - Mark
>
> http://www.lucidimagination.com
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: ant test should include test-tag
Posted by Mark Miller <ma...@gmail.com>.
Wouldn't hurt I suppose - but test-core and test-contrib are probably
sufficient. I wasn't very clear with that comment. I was just saying, as
long as I can still run the tests a bit quicker than running through
everything twice - which is already available. I should have just said
+1. On the other hand, test-core-contrib doesn't hurt anything.
Michael McCandless wrote:
> OK I'll add a "test-core-contrib" target.
>
> Mike
>
> On Thu, Apr 2, 2009 at 6:45 AM, Mark Miller <ma...@gmail.com> wrote:
>
>> Shai Erera wrote:
>>
>>> I definitely agree. It would have saved me another patch submission in
>>> 1575 :)
>>>
>>> On Thu, Apr 2, 2009 at 12:44 PM, Michael McCandless
>>> <lucene@mikemccandless.com <ma...@mikemccandless.com>> wrote:
>>>
>>> I think back-compat tests ("ant test-tag") should run when you run
>>> "ant test".
>>>
>>> Any objections?
>>>
>>> If not I'll commit soon...
>>>
>>> Mike
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>> <ma...@lucene.apache.org>
>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>> <ma...@lucene.apache.org>
>>>
>>>
>>>
>> As long as I still have a target that will test without back compat tests.
>>
>> --
>> - Mark
>>
>> http://www.lucidimagination.com
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
--
- Mark
http://www.lucidimagination.com
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: ant test should include test-tag
Posted by Michael McCandless <lu...@mikemccandless.com>.
OK I'll add a "test-core-contrib" target.
Mike
On Thu, Apr 2, 2009 at 6:45 AM, Mark Miller <ma...@gmail.com> wrote:
> Shai Erera wrote:
>>
>> I definitely agree. It would have saved me another patch submission in
>> 1575 :)
>>
>> On Thu, Apr 2, 2009 at 12:44 PM, Michael McCandless
>> <lucene@mikemccandless.com <ma...@mikemccandless.com>> wrote:
>>
>> I think back-compat tests ("ant test-tag") should run when you run
>> "ant test".
>>
>> Any objections?
>>
>> If not I'll commit soon...
>>
>> Mike
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> <ma...@lucene.apache.org>
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>> <ma...@lucene.apache.org>
>>
>>
> As long as I still have a target that will test without back compat tests.
>
> --
> - Mark
>
> http://www.lucidimagination.com
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: ant test should include test-tag
Posted by Mark Miller <ma...@gmail.com>.
Shai Erera wrote:
> I definitely agree. It would have saved me another patch submission in
> 1575 :)
>
> On Thu, Apr 2, 2009 at 12:44 PM, Michael McCandless
> <lucene@mikemccandless.com <ma...@mikemccandless.com>> wrote:
>
> I think back-compat tests ("ant test-tag") should run when you run
> "ant test".
>
> Any objections?
>
> If not I'll commit soon...
>
> Mike
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> <ma...@lucene.apache.org>
> For additional commands, e-mail: java-dev-help@lucene.apache.org
> <ma...@lucene.apache.org>
>
>
As long as I still have a target that will test without back compat tests.
--
- Mark
http://www.lucidimagination.com
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
Re: ant test should include test-tag
Posted by Shai Erera <se...@gmail.com>.
I definitely agree. It would have saved me another patch submission in 1575
:)
On Thu, Apr 2, 2009 at 12:44 PM, Michael McCandless <
lucene@mikemccandless.com> wrote:
> I think back-compat tests ("ant test-tag") should run when you run "ant
> test".
>
> Any objections?
>
> If not I'll commit soon...
>
> Mike
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>