You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/06 06:40:14 UTC

[GitHub] tzulitai opened a new pull request #7028: [FLINK-10789] New serializer snapshots after 1.6 should implement TypeSerializerSnapshot

tzulitai opened a new pull request #7028: [FLINK-10789] New serializer snapshots after 1.6 should implement TypeSerializerSnapshot
URL: https://github.com/apache/flink/pull/7028
 
 
   ## What is the purpose of the change
   
   Commit 3787b89105c6a005ddca999b0b8a0356e812ede6 added a few new serializer snapshots, but they extend the now deprecated `TypeSerializerConfigSnapshot`. Namely,
   
   - LockableSerializerConfigSnapshot
   - ListViewSerializerConfigSnapshot
   - MapViewSerializerConfigSnapshot
   - ScalaEitherSerializerConfigSnapshot
   
   While this doesn't break things, this means that they will be written with the old format and will require us to add migration code paths for them after the release.
   
   This PR changes so that they implement the new `TypeSerializerSnapshot` interface.
   There is one commit for changing each individual snapshot.
   
   ## Brief change log
   
   - Updated the `LockableSerializerConfigSnapshot` and added a migration test for it
   - Updated the `ListViewSerializerConfigSnapshot` and added a migration test for it. This also explicitly sets the serial version UID for the `ListViewSerializer` otherwise the migration test fails.
   - Updated the `MapViewSerializerConfigSnapshot` and added a migration test for it. This also explicitly sets the serial version UID for the `MapViewSerializer` otherwise the migration test fails.
   - Updated the `ScalaEitherSerializerConfigSnapshot` and added a migration test for it
   
   ## Verifying this change
   
   The change is covered by the new migration tests:
   
   - `LockableTypeSerializerSnapshotMigrationTest`
   - `ListViewSerializerSnapshotMigrationTest`
   - `MapViewSerializerSnapshotMigrationTest`
   - `ScalaEitherSerializerSnapshotMigrationTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (**yes** / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services