You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/03/05 03:24:34 UTC

[GitHub] [kylin] liukun4515 opened a new pull request #1602: [KYLIN-4924] bug fix: check the compatibility for derived column in lambda mode

liukun4515 opened a new pull request #1602:
URL: https://github.com/apache/kylin/pull/1602


   ## Proposed changes
   
   when create lambda table in real-time stream, the derived columns are not be checked compatibility with partition columns in hive table.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
   
   - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
   - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature works
   - [ ] If this change need a document change, I will prepare another pr against the `document` branch
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] coveralls commented on pull request #1602: [KYLIN-4924] bug fix: check the compatibility for derived column in lambda mode

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1602:
URL: https://github.com/apache/kylin/pull/1602#issuecomment-791138178


   ## Pull Request Test Coverage Report for [Build 6935](https://coveralls.io/builds/37675540)
   
   * **0** of **6**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * **3** unchanged lines in **2** files lost coverage.
   * Overall coverage increased (+**0.003%**) to **27.958%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [server-base/src/main/java/org/apache/kylin/rest/controller/StreamingV2Controller.java](https://coveralls.io/builds/37675540/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FStreamingV2Controller.java#L203) | 0 | 6 | 0.0%
   <!-- | **Total:** | **0** | **6** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [server-base/src/main/java/org/apache/kylin/rest/controller/StreamingV2Controller.java](https://coveralls.io/builds/37675540/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FStreamingV2Controller.java#L199) | 1 | 0% |
   | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/37675540/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L193) | 2 | 79.07% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/37675540/badge)](https://coveralls.io/builds/37675540) |
   | :-- | --: |
   | Change from base [Build 6921](https://coveralls.io/builds/37585214): |  0.003% |
   | Covered Lines: | 26259 |
   | Relevant Lines: | 93922 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] liukun4515 commented on pull request #1602: [KYLIN-4924] bug fix: check the compatibility for derived column in lambda mode

Posted by GitBox <gi...@apache.org>.
liukun4515 commented on pull request #1602:
URL: https://github.com/apache/kylin/pull/1602#issuecomment-791124850


   @hit-lacus PTAL


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] codecov-io commented on pull request #1602: [KYLIN-4924] bug fix: check the compatibility for derived column in lambda mode

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1602:
URL: https://github.com/apache/kylin/pull/1602#issuecomment-791135890


   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1602?src=pr&el=h1) Report
   > Merging [#1602](https://codecov.io/gh/apache/kylin/pull/1602?src=pr&el=desc) (45b914d) into [master](https://codecov.io/gh/apache/kylin/commit/af1e59f6e96201b6a6c4912204ff7faa2ec10d5d?el=desc) (af1e59f) will **decrease** coverage by `0.09%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1602/graphs/tree.svg?width=650&height=150&src=pr&token=JawVgbgsVo)](https://codecov.io/gh/apache/kylin/pull/1602?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1602      +/-   ##
   ============================================
   - Coverage     25.51%   25.41%   -0.10%     
   - Complexity     6762     6764       +2     
   ============================================
     Files          1505     1508       +3     
     Lines         93600    93922     +322     
     Branches      13103    13159      +56     
   ============================================
   - Hits          23884    23874      -10     
   - Misses        67342    67667     +325     
   - Partials       2374     2381       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1602?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/kylin/rest/controller/StreamingV2Controller.java](https://codecov.io/gh/apache/kylin/pull/1602/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9TdHJlYW1pbmdWMkNvbnRyb2xsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../apache/kylin/tool/query/ProbabilityGenerator.java](https://codecov.io/gh/apache/kylin/pull/1602/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9xdWVyeS9Qcm9iYWJpbGl0eUdlbmVyYXRvci5qYXZh) | `71.05% <0.00%> (-5.27%)` | `11.00% <0.00%> (ø%)` | |
   | [...n/java/org/apache/kylin/common/util/ClassUtil.java](https://codecov.io/gh/apache/kylin/pull/1602/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0NsYXNzVXRpbC5qYXZh) | `49.20% <0.00%> (-2.47%)` | `9.00% <0.00%> (ø%)` | |
   | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1602/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `73.25% <0.00%> (-2.33%)` | `12.00% <0.00%> (ø%)` | |
   | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1602/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | |
   | [...rg/apache/kylin/source/jdbc/JdbcHiveInputBase.java](https://codecov.io/gh/apache/kylin/pull/1602/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL0pkYmNIaXZlSW5wdXRCYXNlLmphdmE=) | `7.92% <0.00%> (-1.14%)` | `7.00% <0.00%> (ø%)` | |
   | [...va/org/apache/kylin/tool/query/QueryGenerator.java](https://codecov.io/gh/apache/kylin/pull/1602/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9xdWVyeS9RdWVyeUdlbmVyYXRvci5qYXZh) | `80.00% <0.00%> (-1.12%)` | `23.00% <0.00%> (-1.00%)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1602/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0.00%> (-0.92%)` | `7.00% <0.00%> (ø%)` | |
   | [...a/org/apache/kylin/dict/TrieDictionaryBuilder.java](https://codecov.io/gh/apache/kylin/pull/1602/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L1RyaWVEaWN0aW9uYXJ5QnVpbGRlci5qYXZh) | `80.49% <0.00%> (-0.87%)` | `46.00% <0.00%> (+2.00%)` | :arrow_down: |
   | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/1602/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0.00%> (-0.80%)` | `17.00% <0.00%> (-1.00%)` | |
   | ... and [23 more](https://codecov.io/gh/apache/kylin/pull/1602/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1602?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1602?src=pr&el=footer). Last update [af1e59f...45b914d](https://codecov.io/gh/apache/kylin/pull/1602?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] hit-lacus merged pull request #1602: [KYLIN-4924] bug fix: check the compatibility for derived column in lambda mode

Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1602:
URL: https://github.com/apache/kylin/pull/1602


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org