[GitHub] [buildstream] juergbi commented on pull request #1489: requirements/requirements.in: It depends on grpc >= 1.37

[GitBox <gi...@apache.org>]

juergbi commented on pull request #1489:
URL: https://github.com/apache/buildstream/pull/1489#issuecomment-891217077


   Is grpcio 1.37 the minimum version you've determined or is this simply a known working version? In CI even for BuildStream master we still have a minimum of 1.10 declared and we're testing with 1.34 in CI. And for the C++ library we even still test with gRPC 1.16 (Debian 10), gRPC 1.25 (CentOS 7.7 and Ubuntu 18.04) and gRPC 1.26 (Fedora 32/33), as far as I can tell.
   
   gRPC 1.37 is fairly recent. Can this be an issue on older distros or is this a non-issue as everyone is pulling it from PyPI and there are also no indirect dependency issues?
   
   In any case, any potential issues with old grpcio versions likely also apply to BuildStream master. And thus, this should first be fixed in master before a backport to bst-1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org