[jira] [Commented] (DRILL-5168) No direct Streaming Agg test cases

["Khurram Faraaz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15785210#comment-15785210 ] 

Khurram Faraaz commented on DRILL-5168:
---------------------------------------

By default `planner.enable_streamagg` is set to true in sys.options. Some existing Functional tests are testing this option. 
A search on the test framework repo on GitHub returned 42 matching results. Most of those are for tests that verify query plan.

https://github.com/mapr/drill-test-framework/search?utf8=%E2%9C%93&q=StreamAgg

If we need more coverage for StreamAgg we can discuss this.

> No direct Streaming Agg test cases
> ----------------------------------
>
>                 Key: DRILL-5168
>                 URL: https://issues.apache.org/jira/browse/DRILL-5168
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.8.0
>            Reporter: Paul Rogers
>            Priority: Minor
>
> Drill's provides both hash and streaming aggregate operators. Both reside in the {{org.apache.drill.exec.physical.impl.aggregate}} package. The corresponding test package contains tests only for the hash aggregate: {{TestHashAggr}}. No corresponding unit tests exists for streaming aggregates.
> It may be that other, SQL-level tests have the effect of testing streaming aggregates (but I've not yet found such tests.) Without unit tests, we cannot guarantee that changes to streaming aggregates will work correctly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)