You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/12/03 05:43:15 UTC

[GitHub] [carbondata] kunal642 commented on a change in pull request #4017: [CARBONDATA-4022] Fix invalid path issue for segment added through alter table add segment query.

kunal642 commented on a change in pull request #4017:
URL: https://github.com/apache/carbondata/pull/4017#discussion_r534686282



##########
File path: core/src/main/java/org/apache/carbondata/core/indexstore/ExtendedBlocklet.java
##########
@@ -219,7 +220,12 @@ public void deserializeFields(DataInput in, String[] locations, String tablePath
     if (in.readBoolean()) {
       indexUniqueId = in.readUTF();
     }
-    setFilePath(tablePath + getPath());
+    String filePath = getPath();
+    if (filePath.startsWith(File.separator)) {

Review comment:
       better to change this check to 
   ```
   if (filePath.contains(tablePath)) {
   // don't add table path
   } else {
   // add table path
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org