You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/12/10 01:23:34 UTC

DO NOT REPLY [Bug 50448] New: StandardSession.expire causes IllegalStateException: getCreationTime: Session already invalidated

https://issues.apache.org/bugzilla/show_bug.cgi?id=50448

           Summary: StandardSession.expire causes IllegalStateException:
                    getCreationTime: Session already invalidated
           Product: Tomcat 7
           Version: trunk
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: martin.grotzke@googlemail.com


Hi,

when verifying the fix for #50360 I ran into an issue with expired sessions
during processExpires:

Dec 10, 2010 12:59:32 AM org.apache.catalina.core.ContainerBase
backgroundProcess
WARNING: Exception processing manager
de.javakaffee.web.msm.MemcachedBackupSessionManager[/] background process
java.lang.IllegalStateException: getCreationTime: Session already invalidated
    at
org.apache.catalina.session.StandardSession.getCreationTime(StandardSession.java:1096)
    at org.apache.catalina.session.ManagerBase.remove(ManagerBase.java:802)
    at
org.apache.catalina.session.StandardSession.expire(StandardSession.java:840)
    at
org.apache.catalina.session.StandardSession.isValid(StandardSession.java:655)
    at
org.apache.catalina.session.ManagerBase.processExpires(ManagerBase.java:609)
    at
org.apache.catalina.session.ManagerBase.backgroundProcess(ManagerBase.java:594)
    at
de.javakaffee.web.msm.MemcachedBackupSessionManager.backgroundProcess(MemcachedBackupSessionManager.java:1130)
    at
org.apache.catalina.core.ContainerBase.backgroundProcess(ContainerBase.java:1214)

AFAICS in MemcachedBackupSessionManager I could override remove(Session
session, boolean update) with calling super.remove(session, false) for invalid
sessions.

Another option would be to change
StandardSession.expire(StandardSession.java:840) so that it does not invoke
manager.remove(this, true) but manager.remove(this, false).

Or even better: change ManagerBase.remove(ManagerBase.java:802) to invoke some
session.getCreationTimeInternal() which skips validation.

What do you think?

Cheers,
Martin

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 50448] StandardSession.expire causes IllegalStateException: getCreationTime: Session already invalidated

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50448

--- Comment #2 from Martin Grotzke <ma...@googlemail.com> 2010-12-11 08:13:04 EST ---
Thanx for the fix, now all tests for memcached-session-manager are green! Happy
now, looking forward to tomcat 7.0.6. Keep on the great work!

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 50448] StandardSession.expire causes IllegalStateException: getCreationTime: Session already invalidated

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50448

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Mark Thomas <ma...@apache.org> 2010-12-10 08:54:50 EST ---
Thanks for the report. Fixed in 7.0.x and will be included in 7.0.6 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org