[GitHub] [drill] cgivre commented on a change in pull request #2509: DRILL-8181: Accept nullable args in HTTP plugin UDFs, fix HikariCP default parm names

[GitBox <gi...@apache.org>]

cgivre commented on a change in pull request #2509:
URL: https://github.com/apache/drill/pull/2509#discussion_r839538401



##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfigServer.java
##########
@@ -306,6 +306,8 @@ public SslProvider getProvider() {
 
   @Override
   public int getHandshakeTimeout() {
+    // TODO: why do we hard code this when we provide {@link ExecConstants.SSL_HANDSHAKE_TIMEOUT}?

Review comment:
       @jnturton Could you please create a JIRA for this an reference it here?

##########
File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java
##########
@@ -873,29 +873,14 @@ private static HttpStoragePlugin getStoragePlugin(DrillbitContext context, Strin
    * @param args An optional list of parameter arguments which will be included in the URL
    * @return A String of the results.
    */
-  public static String makeAPICall(String schemaPath, DrillbitContext context, List<String> args) {
+  public static String makeAPICall(

Review comment:
       The LGTM isn't liking the Javadocs now that you changed the function args.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org