You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "2010YOUY01 (via GitHub)" <gi...@apache.org> on 2026/09/07 03:14:15 UTC
[PR] chore: Clean up out-of-date comments for aggregate refactor [datafusion]
2010YOUY01 opened a new pull request, #25007:
URL: https://github.com/apache/datafusion/pull/25007
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of https://github.com/apache/datafusion/issues/25006
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
Please explain the problem you are trying to solve in terms of the user-visible
behavior, rather than the implementation.
For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of the
implementation. "COUNT(DISTINCT) returns wrong results when the column contains
nulls" is the user-visible problem.
-->
The refactor has been completed functionally, this PR updates the comments to keep things in sync.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here, but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## What is the testing strategy for this PR?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
Briefly describe how this PR is tested, and point to the specific tests you added. For example: 'This new feature is covered by the `sqllogictest` cases added in `foo.slt`'.
If this PR does not add tests, explain why. For example, if the change is already covered by existing tests, please mention it.
You should also check the `codecov` bot reply on this PR to confirm the changed code is exercised.
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Clean up out-of-date comments for aggregate refactor [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #25007:
URL: https://github.com/apache/datafusion/pull/25007#discussion_r3960551874
##########
datafusion/common/src/config.rs:
##########
@@ -964,13 +964,14 @@ config_namespace! {
/// the new schema verification step.
pub skip_physical_aggregate_schema_check: bool, default = false
- /// Temporary switch for aggregate stream implementations that are being
- /// migrated from `GroupedHashAggregateStream`.
+ /// Temporary switch for the aggregate stream implementations that were
+ /// split out of `GroupedHashAggregateStream`.
///
- /// When set to true, DataFusion tries the migrated implementations when
- /// their preconditions are satisfied. When set to false, grouped
- /// aggregation falls back to `GroupedHashAggregateStream`. This option
- /// will be removed after the migration is finished.
+ /// The split is complete, so the default `true` plans every grouped
Review Comment:
I recommend focusing this more on the end user behavior -- something like
```rust
/// When set to false, falls back to the pre 55.0.0 aggregation code.
/// The fallback is intended as a workaround in case of bugs and
/// will be deleted after the 56.0.0 release together with this option.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Clean up out-of-date comments for aggregate refactor [datafusion]
Posted by "2010YOUY01 (via GitHub)" <gi...@apache.org>.
2010YOUY01 merged PR #25007:
URL: https://github.com/apache/datafusion/pull/25007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Clean up out-of-date comments for aggregate refactor [datafusion]
Posted by "2010YOUY01 (via GitHub)" <gi...@apache.org>.
2010YOUY01 commented on code in PR #25007:
URL: https://github.com/apache/datafusion/pull/25007#discussion_r3964410224
##########
datafusion/common/src/config.rs:
##########
@@ -964,13 +964,14 @@ config_namespace! {
/// the new schema verification step.
pub skip_physical_aggregate_schema_check: bool, default = false
- /// Temporary switch for aggregate stream implementations that are being
- /// migrated from `GroupedHashAggregateStream`.
+ /// Temporary switch for the aggregate stream implementations that were
+ /// split out of `GroupedHashAggregateStream`.
///
- /// When set to true, DataFusion tries the migrated implementations when
- /// their preconditions are satisfied. When set to false, grouped
- /// aggregation falls back to `GroupedHashAggregateStream`. This option
- /// will be removed after the migration is finished.
+ /// The split is complete, so the default `true` plans every grouped
Review Comment:
I agree, updated in [deb84dc](https://github.com/apache/datafusion/pull/25007/commits/deb84dc0962e03b7d18fc26fed913d81615fa5c2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Clean up out-of-date comments for aggregate refactor [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #25007:
URL: https://github.com/apache/datafusion/pull/25007#issuecomment-5565187820
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/25007?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 81.69%. Comparing base ([`2c31327`](https://app.codecov.io/gh/apache/datafusion/commit/2c31327c683ec3f383c9993c4c08647622fa5dd3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b7f42bb`](https://app.codecov.io/gh/apache/datafusion/commit/b7f42bb5e3951b034cbe2cfd5867ecd915c8cbc5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #25007 +/- ##
==========================================
- Coverage 81.69% 81.69% -0.01%
==========================================
Files 1127 1127
Lines 415386 415471 +85
Branches 415386 415471 +85
==========================================
+ Hits 339360 339417 +57
- Misses 56091 56111 +20
- Partials 19935 19943 +8
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/25007?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org