You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by up...@apache.org on 2019/12/27 17:06:31 UTC
[geode] branch develop updated: GEOE-7617: Retry awaits in
GeodeClientClusterManagementSSLTest
This is an automated email from the ASF dual-hosted git repository.
upthewaterspout pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/develop by this push:
new 51d1b24 GEOE-7617: Retry awaits in GeodeClientClusterManagementSSLTest
51d1b24 is described below
commit 51d1b245643e97c0f92bd39abe89e8e744d476cf
Author: Dan Smith <up...@apache.org>
AuthorDate: Fri Dec 27 09:06:08 2019 -0800
GEOE-7617: Retry awaits in GeodeClientClusterManagementSSLTest
This test had an awaitility clause. Unfortunately, awaitility only retries the expression if it throws an AssertionError. In this case the clause was throwing an IllegalStateException. We want to retry if the IllegalStateException is thrown. Adding a catch and rethrow to tell awaitility to retry.
---
.../internal/rest/GeodeClientClusterManagementSSLTest.java | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/geode-assembly/src/distributedTest/java/org/apache/geode/management/internal/rest/GeodeClientClusterManagementSSLTest.java b/geode-assembly/src/distributedTest/java/org/apache/geode/management/internal/rest/GeodeClientClusterManagementSSLTest.java
index 6550959..543c6d3 100644
--- a/geode-assembly/src/distributedTest/java/org/apache/geode/management/internal/rest/GeodeClientClusterManagementSSLTest.java
+++ b/geode-assembly/src/distributedTest/java/org/apache/geode/management/internal/rest/GeodeClientClusterManagementSSLTest.java
@@ -67,9 +67,13 @@ public class GeodeClientClusterManagementSSLTest {
public void getServiceUseClientSSLConfig() throws Exception {
client.invoke(() -> {
await().untilAsserted(() -> {
- ClusterManagementService service = buildWithCache()
- .setCache(ClusterStartupRule.getClientCache()).build();
- assertThat(service.isConnected()).isTrue();
+ try {
+ ClusterManagementService service = buildWithCache()
+ .setCache(ClusterStartupRule.getClientCache()).build();
+ assertThat(service.isConnected()).isTrue();
+ } catch (IllegalStateException e) {
+ throw new AssertionError(e);
+ }
});
});
}