[GitHub] [pinot] saurabhd336 commented on a diff in pull request #11511: Add auto generated query tests for tpch

["saurabhd336 (via GitHub)" <gi...@apache.org>]

saurabhd336 commented on code in PR #11511:
URL: https://github.com/apache/pinot/pull/11511#discussion_r1315402292


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/DocIdDictionary.java:
##########
@@ -45,6 +45,11 @@ public int insertionIndexOf(String stringValue) {
     }
   }
 
+  @Override
+  public int indexOf(int value) {

Review Comment:
   This change is needed to be able to support `$docId IN` queries



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org