You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Saqeeb Shaikh <sa...@freestoneinfotech.com> on 2019/12/19 14:20:09 UTC

Review Request 71929: ATLAS-3565 :: Atlas server should set startTime and endTime for hive_process to System.currentTimeMillis() if either of these are null.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71929/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-3565
    https://issues.apache.org/jira/browse/ATLAS-3565


Repository: atlas


Description
-------

For entity type hive_process startTime and endTime are compulsory attributes, if they are null then atlas server should set current system time for those attributes.


Diffs
-----

  webapp/src/main/java/org/apache/atlas/notification/preprocessor/EntityPreprocessor.java 0cddd41 
  webapp/src/main/java/org/apache/atlas/notification/preprocessor/HivePreprocessor.java d31495c 


Diff: https://reviews.apache.org/r/71929/diff/1/


Testing
-------

Pre commit build :: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1593/console

Manually verified with JSON having huge number of columns.


Thanks,

Saqeeb Shaikh


Re: Review Request 71929: ATLAS-3565 :: Atlas server should set startTime and endTime for hive_process to System.currentTimeMillis() if either of these are null.

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71929/#review219066
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Dec. 19, 2019, 2:20 p.m., Saqeeb Shaikh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71929/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2019, 2:20 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3565
>     https://issues.apache.org/jira/browse/ATLAS-3565
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> For entity type hive_process startTime and endTime are compulsory attributes, if they are null then atlas server should set current system time for those attributes.
> 
> 
> Diffs
> -----
> 
>   webapp/src/main/java/org/apache/atlas/notification/preprocessor/EntityPreprocessor.java 0cddd41 
>   webapp/src/main/java/org/apache/atlas/notification/preprocessor/HivePreprocessor.java d31495c 
> 
> 
> Diff: https://reviews.apache.org/r/71929/diff/1/
> 
> 
> Testing
> -------
> 
> Pre commit build :: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1593/console
> 
> Manually verified with JSON having huge number of columns.
> 
> 
> Thanks,
> 
> Saqeeb Shaikh
> 
>


Re: Review Request 71929: ATLAS-3565 :: Atlas server should set startTime and endTime for hive_process to System.currentTimeMillis() if either of these are null.

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71929/#review219071
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Dec. 19, 2019, 6:20 a.m., Saqeeb Shaikh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71929/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2019, 6:20 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3565
>     https://issues.apache.org/jira/browse/ATLAS-3565
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> For entity type hive_process startTime and endTime are compulsory attributes, if they are null then atlas server should set current system time for those attributes.
> 
> 
> Diffs
> -----
> 
>   webapp/src/main/java/org/apache/atlas/notification/preprocessor/EntityPreprocessor.java 0cddd41 
>   webapp/src/main/java/org/apache/atlas/notification/preprocessor/HivePreprocessor.java d31495c 
> 
> 
> Diff: https://reviews.apache.org/r/71929/diff/1/
> 
> 
> Testing
> -------
> 
> Pre commit build :: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1593/console
> 
> Manually verified with JSON having huge number of columns.
> 
> 
> Thanks,
> 
> Saqeeb Shaikh
> 
>