You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/02 23:47:34 UTC

[GitHub] [hudi] rkkalluri commented on a change in pull request #5205: [HUDI-3726] Harden constraints around switching between different key generators

rkkalluri commented on a change in pull request #5205:
URL: https://github.com/apache/hudi/pull/5205#discussion_r841131945



##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieWriterUtils.scala
##########
@@ -115,7 +116,12 @@ object HoodieWriterUtils {
   }
 
   def getOriginKeyGenerator(parameters: Map[String, String]): String = {
-    val kg = parameters.getOrElse(KEYGENERATOR_CLASS_NAME.key(), null)
+    //first check table config for key generator
+    var kg = parameters.getOrElse(HoodieTableConfig.KEY_GENERATOR_CLASS_NAME.key, null)

Review comment:
       You mean like this ?
   
   var kg = parameters.getOrElse(HoodieTableConfig.KEY_GENERATOR_CLASS_NAME.key, parameters.getOrElse(KEYGENERATOR_CLASS_NAME.key(), KEYGENERATOR_CLASS_NAME.defaultValue()))
   
   The only drawback to this is it might affect readability.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org