You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/22 08:13:45 UTC
[GitHub] [pulsar] Technoboy- opened a new pull request, #16170: [fix][admin] Fix get non-persistent topics issue in Namespaces.
Technoboy- opened a new pull request, #16170:
URL: https://github.com/apache/pulsar/pull/16170
Master Issue: #16081
### Motivation
Currently, we can use `admin.namespaces().getTopics` to get topics under a namespace. But it could only return the non-persistent topics owned by the current broker.
Also, we can use `admin.toipics().getList` to get topics. It can return all non-persistent topics to users.
I think it is reasonable that we should make the data return of these two interfaces consistent.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
- [x] `doc-not-needed`
(Please explain why)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #16170: [fix][admin] Fix get non-persistent topics issue in Namespaces.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on PR #16170:
URL: https://github.com/apache/pulsar/pull/16170#issuecomment-1179900544
> Hi @Technoboy-
>
> It looks like we have some conflict with branch-2.9. Could you please help cherry-pick it?
Yes, done. https://github.com/apache/pulsar/pull/16514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #16170: [fix][admin] Fix get non-persistent topics issue in Namespaces.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #16170:
URL: https://github.com/apache/pulsar/pull/16170#discussion_r905655646
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java:
##########
@@ -114,12 +114,12 @@ public void getTenantNamespaces(@Suspended final AsyncResponse response,
public void getTopics(@Suspended AsyncResponse response,
@PathParam("tenant") String tenant,
@PathParam("namespace") String namespace,
- @QueryParam("mode") @DefaultValue("PERSISTENT") Mode mode) {
+ @QueryParam("mode") @DefaultValue("ALL") Mode mode) {
Review Comment:
Ah, a mistake for this line. Fixing another problem, resulting in no time to modify. Thanks for the review.
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #16170: [fix][admin] Fix get non-persistent topics issue in Namespaces.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #16170:
URL: https://github.com/apache/pulsar/pull/16170#issuecomment-1179656990
@Technoboy- Please also help cherry-pick to branch-2.10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a diff in pull request #16170: [fix][admin] Fix get non-persistent topics issue in Namespaces.
Posted by GitBox <gi...@apache.org>.
eolivelli commented on code in PR #16170:
URL: https://github.com/apache/pulsar/pull/16170#discussion_r904637026
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java:
##########
@@ -114,12 +114,12 @@ public void getTenantNamespaces(@Suspended final AsyncResponse response,
public void getTopics(@Suspended AsyncResponse response,
@PathParam("tenant") String tenant,
@PathParam("namespace") String namespace,
- @QueryParam("mode") @DefaultValue("PERSISTENT") Mode mode) {
+ @QueryParam("mode") @DefaultValue("ALL") Mode mode) {
Review Comment:
this is a breaking change
I suspect it will give problems to the users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #16170: [fix][admin] Fix get non-persistent topics issue in Namespaces.
Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #16170:
URL: https://github.com/apache/pulsar/pull/16170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #16170: [fix][admin] Fix get non-persistent topics issue in Namespaces.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #16170:
URL: https://github.com/apache/pulsar/pull/16170#issuecomment-1172823516
Hi @Technoboy-
It looks like we have some conflict with branch-2.9. Could you please help cherry-pick it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #16170: [fix][admin] Fix get non-persistent topics issue in Namespaces.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on PR #16170:
URL: https://github.com/apache/pulsar/pull/16170#issuecomment-1179900698
> @Technoboy- Please also help cherry-pick to branch-2.10.
Ok, done. https://github.com/apache/pulsar/pull/16514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org