You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kk...@apache.org on 2011/01/08 02:09:55 UTC

svn commit: r1056583 - /tomcat/trunk/test/org/apache/catalina/valves/TestRemoteIpValve.java

Author: kkolinko
Date: Sat Jan  8 01:09:54 2011
New Revision: 1056583

URL: http://svn.apache.org/viewvc?rev=1056583&view=rev
Log:
Correct typo in the method names in a test case, so that they match to what method is actually being tested.

Modified:
    tomcat/trunk/test/org/apache/catalina/valves/TestRemoteIpValve.java

Modified: tomcat/trunk/test/org/apache/catalina/valves/TestRemoteIpValve.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/valves/TestRemoteIpValve.java?rev=1056583&r1=1056582&r2=1056583&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/valves/TestRemoteIpValve.java (original)
+++ tomcat/trunk/test/org/apache/catalina/valves/TestRemoteIpValve.java Sat Jan  8 01:09:54 2011
@@ -71,13 +71,13 @@ public class TestRemoteIpValve extends T
         }
     }
     
-    public void testCommaDelimitedListToStringArray() {
+    public void testListToCommaDelimitedString() {
         List<String> elements = Arrays.asList("element1", "element2", "element3");
         String actual = RemoteIpValve.listToCommaDelimitedString(elements);
         assertEquals("element1, element2, element3", actual);
     }
     
-    public void testCommaDelimitedListToStringArrayEmptyList() {
+    public void testListToCommaDelimitedStringEmptyList() {
         List<String> elements = new ArrayList<String>();
         String actual = RemoteIpValve.listToCommaDelimitedString(elements);
         assertEquals("", actual);
@@ -625,7 +625,7 @@ public class TestRemoteIpValve extends T
         assertEquals("postInvoke remoteAddr", "remote-host-original-value", actualPostInvokeRemoteHost);
     }
     
-    public void testListToCommaDelimitedString() {
+    public void testCommaDelimitedListToStringArray() {
         String[] actual = RemoteIpValve.commaDelimitedListToStringArray("element1, element2, element3");
         String[] expected = new String[] {
             "element1", "element2", "element3"
@@ -633,7 +633,7 @@ public class TestRemoteIpValve extends T
         assertArrayEquals(expected, actual);
     }
     
-    public void testListToCommaDelimitedStringMixedSpaceChars() {
+    public void testCommaDelimitedListToStringArrayMixedSpaceChars() {
         String[] actual = RemoteIpValve.commaDelimitedListToStringArray("element1  , element2,\t element3");
         String[] expected = new String[] {
             "element1", "element2", "element3"



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org