You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by "atiaomar1978-hub (via GitHub)" <gi...@apache.org> on 2026/08/02 12:18:24 UTC

Re: [PR] CAMEL-18552: camel-jbang --openapi-ui with Swagger UI at /q/openapi [camel]

atiaomar1978-hub commented on PR #25202:
URL: https://github.com/apache/camel/pull/25202#issuecomment-5157800166

   _AI-generated comment on behalf of [atiaomar1978-hub](https://github.com/atiaomar1978-hub)_
   
   ### Review follow-up (`129a83f5196`)
   
   Addressed @gnodet's latest observations:
   
   1. **Dependency scope** — `swagger-ui` webjar in `camel-platform-http-main/pom.xml` is now `<optional>true</optional>` so the ~4MB asset is not transitively pulled into downstream BOM consumers; JBang still adds `camel:platform-http-main` explicitly when `--openapi-ui` is used.
   
   2. **Override behavior** — 4.22 upgrade guide now documents that `--openapi-ui` sets override properties for `camel.rest.component=platform-http` and `camel.rest.apiContextPath=/q/openapi.json` (taking precedence over `application.properties`).
   
   3. **Test coverage** — extracted `applyOpenApiUiRuntimeOptions()` and added `shouldApplyOpenApiUiOverrideProperties` in `RunOpenApiUiOptionsTest`.
   
   **Tests (all green locally):**
   - `OpenApiUiHttpServerTest`, `OpenApiUiRestMainTest`, `OpenApiUiSupportTest` (8 tests)
   - `RunOpenApiUiOptionsTest` (4 tests)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org