You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2017/03/20 05:52:58 UTC
Review Request 57738: Enable cbo in presence of hints
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57738/
-----------------------------------------------------------
Review request for hive and pengcheng xiong.
Bugs: HIVE-16230
https://issues.apache.org/jira/browse/HIVE-16230
Repository: hive-git
Description
-------
Were disabled earlier.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java 5b2c9c0
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java fc7d510
ql/src/test/queries/clientnegative/bucket_mapjoin_mismatch1.q ff982c6
ql/src/test/queries/clientnegative/bucket_mapjoin_wrong_table_metadata_1.q fa91552
ql/src/test/queries/clientnegative/bucket_mapjoin_wrong_table_metadata_2.q b392c42
ql/src/test/queries/clientnegative/invalid_mapjoin1.q 56d9211
ql/src/test/queries/clientnegative/join2.q 98a5f1e
ql/src/test/queries/clientnegative/join28.q 32ff105
ql/src/test/queries/clientnegative/join29.q 53a1652
ql/src/test/queries/clientnegative/join32.q 54a4dcd
ql/src/test/queries/clientnegative/join35.q fc8f77c
ql/src/test/queries/clientnegative/smb_bucketmapjoin.q c252d86
ql/src/test/queries/clientnegative/smb_mapjoin_14.q 688989a
ql/src/test/queries/clientnegative/sortmerge_mapjoin_mismatch_1.q 8fbbd96
ql/src/test/queries/clientnegative/union22.q c745d2a
ql/src/test/queries/clientpositive/auto_sortmerge_join_11.q 2dbde47
ql/src/test/queries/clientpositive/bucket_map_join_1.q a92ffa4
ql/src/test/queries/clientpositive/bucket_map_join_2.q 4aa6f57
ql/src/test/queries/clientpositive/bucketcontext_1.q eb9c273
ql/src/test/queries/clientpositive/bucketcontext_2.q 394a7ff
ql/src/test/queries/clientpositive/bucketcontext_3.q 5bf235c
ql/src/test/queries/clientpositive/bucketcontext_4.q 95b67a4
ql/src/test/queries/clientpositive/bucketcontext_5.q 67821ce
ql/src/test/queries/clientpositive/bucketcontext_6.q 8d77243
ql/src/test/queries/clientpositive/bucketcontext_7.q de6ef76
ql/src/test/queries/clientpositive/bucketcontext_8.q 0a60c1a
ql/src/test/queries/clientpositive/bucketmapjoin10.q d9b7edf
ql/src/test/queries/clientpositive/bucketmapjoin11.q 3c630ef
ql/src/test/queries/clientpositive/bucketmapjoin12.q 4229c5c
ql/src/test/queries/clientpositive/bucketmapjoin13.q c8f01f7
ql/src/test/queries/clientpositive/bucketmapjoin5.q 385087e
ql/src/test/queries/clientpositive/bucketmapjoin7.q 3830e9d
ql/src/test/queries/clientpositive/bucketmapjoin8.q 99eeabd
ql/src/test/queries/clientpositive/bucketmapjoin9.q 13189bc
ql/src/test/queries/clientpositive/bucketmapjoin_negative.q 0d84fdd
ql/src/test/queries/clientpositive/bucketmapjoin_negative2.q 93780dc
ql/src/test/queries/clientpositive/bucketmapjoin_negative3.q 51dc40b
ql/src/test/queries/clientpositive/comments.q cacb689
ql/src/test/queries/clientpositive/infer_bucket_sort_map_operators.q 3d57083
ql/src/test/queries/clientpositive/join25.q b093d69
ql/src/test/queries/clientpositive/join26.q d90ce40
ql/src/test/queries/clientpositive/join27.q a9000be
ql/src/test/queries/clientpositive/join30.q 292a310
ql/src/test/queries/clientpositive/join36.q ed71439
ql/src/test/queries/clientpositive/join37.q e029415
ql/src/test/queries/clientpositive/join38.q 7fbe377
ql/src/test/queries/clientpositive/join39.q ab12158
ql/src/test/queries/clientpositive/join40.q 1e6b2b3
ql/src/test/queries/clientpositive/join_map_ppr.q 23070b1
ql/src/test/queries/clientpositive/join_on_varchar.q a1ce1ff
ql/src/test/queries/clientpositive/join_reorder.q 55aaaed
ql/src/test/queries/clientpositive/join_reorder2.q ca1e65e
ql/src/test/queries/clientpositive/join_reorder3.q 994be16
ql/src/test/queries/clientpositive/join_reorder4.q 16ef204
ql/src/test/queries/clientpositive/mapjoin1.q 70bfe2e
ql/src/test/queries/clientpositive/mapjoin_distinct.q d021c63
ql/src/test/queries/clientpositive/pcs.q 0667e95
ql/src/test/queries/clientpositive/skewjoin.q 52b8639
ql/src/test/queries/clientpositive/smb_mapjoin9.q c297447
ql/src/test/queries/clientpositive/smb_mapjoin_1.q 6051e4e1
ql/src/test/queries/clientpositive/smb_mapjoin_10.q cd332c8
ql/src/test/queries/clientpositive/smb_mapjoin_11.q ccb97b3
ql/src/test/queries/clientpositive/smb_mapjoin_12.q 7a506ad
ql/src/test/queries/clientpositive/smb_mapjoin_13.q 744db88
ql/src/test/queries/clientpositive/smb_mapjoin_16.q bff11dd
ql/src/test/queries/clientpositive/smb_mapjoin_2.q 672cd54
ql/src/test/queries/clientpositive/smb_mapjoin_3.q 48f6ed2
ql/src/test/queries/clientpositive/smb_mapjoin_7.q f0b41a4
ql/src/test/queries/clientpositive/sort_merge_join_desc_1.q efa0178
ql/src/test/queries/clientpositive/sort_merge_join_desc_2.q 2b787b8
ql/src/test/queries/clientpositive/sort_merge_join_desc_3.q bdc550c
ql/src/test/queries/clientpositive/sort_merge_join_desc_4.q 89a26fd
ql/src/test/queries/clientpositive/sort_merge_join_desc_5.q 9f32f53
ql/src/test/queries/clientpositive/sort_merge_join_desc_6.q e733538
ql/src/test/queries/clientpositive/sort_merge_join_desc_7.q fe523be
ql/src/test/queries/clientpositive/sort_merge_join_desc_8.q 4c0975d
ql/src/test/queries/clientpositive/vectorized_bucketmapjoin1.q 191d8c6
ql/src/test/results/clientpositive/comments.q.out 4395cb2
ql/src/test/results/clientpositive/join25.q.out 5f3f01c
ql/src/test/results/clientpositive/join26.q.out 8004208
ql/src/test/results/clientpositive/join27.q.out fce7d95
ql/src/test/results/clientpositive/join30.q.out 9d29cef
ql/src/test/results/clientpositive/join36.q.out 206d5ff
ql/src/test/results/clientpositive/join37.q.out 5ee88f7
ql/src/test/results/clientpositive/join38.q.out aca06b2
ql/src/test/results/clientpositive/join39.q.out ee99675
ql/src/test/results/clientpositive/join40.q.out 949c8fb
ql/src/test/results/clientpositive/join_on_varchar.q.out ace445d
ql/src/test/results/clientpositive/join_reorder.q.out 5cef0c9
ql/src/test/results/clientpositive/join_reorder4.q.out c41407f
ql/src/test/results/clientpositive/llap/bucketmapjoin1.q.out 93efa3c
ql/src/test/results/clientpositive/llap/bucketmapjoin2.q.out cea632b
ql/src/test/results/clientpositive/llap/bucketmapjoin3.q.out 4aa0e0e
ql/src/test/results/clientpositive/llap/bucketmapjoin4.q.out 21ce1f8
ql/src/test/results/clientpositive/llap/explainuser_1.q.out 53839a3
ql/src/test/results/clientpositive/llap/join_filters.q.out b730d30
ql/src/test/results/clientpositive/llap/join_nulls.q.out c9876d3
ql/src/test/results/clientpositive/llap/skewjoin.q.out 1251b67
ql/src/test/results/clientpositive/llap/smb_mapjoin_14.q.out 8dee9ff
ql/src/test/results/clientpositive/llap/smb_mapjoin_15.q.out 20766c2
ql/src/test/results/clientpositive/llap/smb_mapjoin_17.q.out a97a692
ql/src/test/results/clientpositive/llap/smb_mapjoin_4.q.out 7d7d96d
ql/src/test/results/clientpositive/llap/smb_mapjoin_5.q.out 1abe220
ql/src/test/results/clientpositive/llap/smb_mapjoin_6.q.out bbf9b46
ql/src/test/results/clientpositive/llap/stats11.q.out 3eccf52
ql/src/test/results/clientpositive/llap/table_access_keys_stats.q.out 48ea4ce
ql/src/test/results/clientpositive/mapjoin1.q.out 5601bc0
ql/src/test/results/clientpositive/mapjoin_distinct.q.out d49c172
ql/src/test/results/clientpositive/mapjoin_hook.q.out 8a6743c
ql/src/test/results/clientpositive/pcs.q.out c422a3d
ql/src/test/results/clientpositive/skewjoin.q.out e792381
ql/src/test/results/clientpositive/spark/bucketmapjoin1.q.out 6333f2c
ql/src/test/results/clientpositive/spark/bucketmapjoin2.q.out 58fe4ab
ql/src/test/results/clientpositive/spark/bucketmapjoin3.q.out 06ce6f5
ql/src/test/results/clientpositive/spark/bucketmapjoin4.q.out 94636f2
ql/src/test/results/clientpositive/spark/join25.q.out bd44295
ql/src/test/results/clientpositive/spark/join26.q.out 4a85a29
ql/src/test/results/clientpositive/spark/join27.q.out 0dfad72
ql/src/test/results/clientpositive/spark/join30.q.out 8360400
ql/src/test/results/clientpositive/spark/join36.q.out 49167f3
ql/src/test/results/clientpositive/spark/join37.q.out 231ca22
ql/src/test/results/clientpositive/spark/join38.q.out 5177dca
ql/src/test/results/clientpositive/spark/join39.q.out 5a5aeb4
ql/src/test/results/clientpositive/spark/join_reorder.q.out eae5426
ql/src/test/results/clientpositive/spark/join_reorder4.q.out 83ea4c5
ql/src/test/results/clientpositive/spark/mapjoin1.q.out ca489e4
ql/src/test/results/clientpositive/spark/mapjoin_distinct.q.out 6b3fcc0
ql/src/test/results/clientpositive/spark/skewjoin.q.out dade580
ql/src/test/results/clientpositive/spark/smb_mapjoin_14.q.out 68cd0fb
ql/src/test/results/clientpositive/spark/smb_mapjoin_15.q.out 5372615
ql/src/test/results/clientpositive/spark/smb_mapjoin_17.q.out 25e29f6
ql/src/test/results/clientpositive/spark/smb_mapjoin_4.q.out 476971b
ql/src/test/results/clientpositive/spark/smb_mapjoin_5.q.out be2ff37
ql/src/test/results/clientpositive/spark/smb_mapjoin_6.q.out 5ae3845
ql/src/test/results/clientpositive/spark/table_access_keys_stats.q.out 923441a
Diff: https://reviews.apache.org/r/57738/diff/1/
Testing
-------
Existing regression tests.
Thanks,
Ashutosh Chauhan
Re: Review Request 57738: Enable cbo in presence of hints
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57738/#review169471
-----------------------------------------------------------
Ship it!
Ship It!
- pengcheng xiong
On March 20, 2017, 5:52 a.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57738/
> -----------------------------------------------------------
>
> (Updated March 20, 2017, 5:52 a.m.)
>
>
> Review request for hive and pengcheng xiong.
>
>
> Bugs: HIVE-16230
> https://issues.apache.org/jira/browse/HIVE-16230
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Were disabled earlier.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java 5b2c9c0
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java fc7d510
> ql/src/test/queries/clientnegative/bucket_mapjoin_mismatch1.q ff982c6
> ql/src/test/queries/clientnegative/bucket_mapjoin_wrong_table_metadata_1.q fa91552
> ql/src/test/queries/clientnegative/bucket_mapjoin_wrong_table_metadata_2.q b392c42
> ql/src/test/queries/clientnegative/invalid_mapjoin1.q 56d9211
> ql/src/test/queries/clientnegative/join2.q 98a5f1e
> ql/src/test/queries/clientnegative/join28.q 32ff105
> ql/src/test/queries/clientnegative/join29.q 53a1652
> ql/src/test/queries/clientnegative/join32.q 54a4dcd
> ql/src/test/queries/clientnegative/join35.q fc8f77c
> ql/src/test/queries/clientnegative/smb_bucketmapjoin.q c252d86
> ql/src/test/queries/clientnegative/smb_mapjoin_14.q 688989a
> ql/src/test/queries/clientnegative/sortmerge_mapjoin_mismatch_1.q 8fbbd96
> ql/src/test/queries/clientnegative/union22.q c745d2a
> ql/src/test/queries/clientpositive/auto_sortmerge_join_11.q 2dbde47
> ql/src/test/queries/clientpositive/bucket_map_join_1.q a92ffa4
> ql/src/test/queries/clientpositive/bucket_map_join_2.q 4aa6f57
> ql/src/test/queries/clientpositive/bucketcontext_1.q eb9c273
> ql/src/test/queries/clientpositive/bucketcontext_2.q 394a7ff
> ql/src/test/queries/clientpositive/bucketcontext_3.q 5bf235c
> ql/src/test/queries/clientpositive/bucketcontext_4.q 95b67a4
> ql/src/test/queries/clientpositive/bucketcontext_5.q 67821ce
> ql/src/test/queries/clientpositive/bucketcontext_6.q 8d77243
> ql/src/test/queries/clientpositive/bucketcontext_7.q de6ef76
> ql/src/test/queries/clientpositive/bucketcontext_8.q 0a60c1a
> ql/src/test/queries/clientpositive/bucketmapjoin10.q d9b7edf
> ql/src/test/queries/clientpositive/bucketmapjoin11.q 3c630ef
> ql/src/test/queries/clientpositive/bucketmapjoin12.q 4229c5c
> ql/src/test/queries/clientpositive/bucketmapjoin13.q c8f01f7
> ql/src/test/queries/clientpositive/bucketmapjoin5.q 385087e
> ql/src/test/queries/clientpositive/bucketmapjoin7.q 3830e9d
> ql/src/test/queries/clientpositive/bucketmapjoin8.q 99eeabd
> ql/src/test/queries/clientpositive/bucketmapjoin9.q 13189bc
> ql/src/test/queries/clientpositive/bucketmapjoin_negative.q 0d84fdd
> ql/src/test/queries/clientpositive/bucketmapjoin_negative2.q 93780dc
> ql/src/test/queries/clientpositive/bucketmapjoin_negative3.q 51dc40b
> ql/src/test/queries/clientpositive/comments.q cacb689
> ql/src/test/queries/clientpositive/infer_bucket_sort_map_operators.q 3d57083
> ql/src/test/queries/clientpositive/join25.q b093d69
> ql/src/test/queries/clientpositive/join26.q d90ce40
> ql/src/test/queries/clientpositive/join27.q a9000be
> ql/src/test/queries/clientpositive/join30.q 292a310
> ql/src/test/queries/clientpositive/join36.q ed71439
> ql/src/test/queries/clientpositive/join37.q e029415
> ql/src/test/queries/clientpositive/join38.q 7fbe377
> ql/src/test/queries/clientpositive/join39.q ab12158
> ql/src/test/queries/clientpositive/join40.q 1e6b2b3
> ql/src/test/queries/clientpositive/join_map_ppr.q 23070b1
> ql/src/test/queries/clientpositive/join_on_varchar.q a1ce1ff
> ql/src/test/queries/clientpositive/join_reorder.q 55aaaed
> ql/src/test/queries/clientpositive/join_reorder2.q ca1e65e
> ql/src/test/queries/clientpositive/join_reorder3.q 994be16
> ql/src/test/queries/clientpositive/join_reorder4.q 16ef204
> ql/src/test/queries/clientpositive/mapjoin1.q 70bfe2e
> ql/src/test/queries/clientpositive/mapjoin_distinct.q d021c63
> ql/src/test/queries/clientpositive/pcs.q 0667e95
> ql/src/test/queries/clientpositive/skewjoin.q 52b8639
> ql/src/test/queries/clientpositive/smb_mapjoin9.q c297447
> ql/src/test/queries/clientpositive/smb_mapjoin_1.q 6051e4e1
> ql/src/test/queries/clientpositive/smb_mapjoin_10.q cd332c8
> ql/src/test/queries/clientpositive/smb_mapjoin_11.q ccb97b3
> ql/src/test/queries/clientpositive/smb_mapjoin_12.q 7a506ad
> ql/src/test/queries/clientpositive/smb_mapjoin_13.q 744db88
> ql/src/test/queries/clientpositive/smb_mapjoin_16.q bff11dd
> ql/src/test/queries/clientpositive/smb_mapjoin_2.q 672cd54
> ql/src/test/queries/clientpositive/smb_mapjoin_3.q 48f6ed2
> ql/src/test/queries/clientpositive/smb_mapjoin_7.q f0b41a4
> ql/src/test/queries/clientpositive/sort_merge_join_desc_1.q efa0178
> ql/src/test/queries/clientpositive/sort_merge_join_desc_2.q 2b787b8
> ql/src/test/queries/clientpositive/sort_merge_join_desc_3.q bdc550c
> ql/src/test/queries/clientpositive/sort_merge_join_desc_4.q 89a26fd
> ql/src/test/queries/clientpositive/sort_merge_join_desc_5.q 9f32f53
> ql/src/test/queries/clientpositive/sort_merge_join_desc_6.q e733538
> ql/src/test/queries/clientpositive/sort_merge_join_desc_7.q fe523be
> ql/src/test/queries/clientpositive/sort_merge_join_desc_8.q 4c0975d
> ql/src/test/queries/clientpositive/vectorized_bucketmapjoin1.q 191d8c6
> ql/src/test/results/clientpositive/comments.q.out 4395cb2
> ql/src/test/results/clientpositive/join25.q.out 5f3f01c
> ql/src/test/results/clientpositive/join26.q.out 8004208
> ql/src/test/results/clientpositive/join27.q.out fce7d95
> ql/src/test/results/clientpositive/join30.q.out 9d29cef
> ql/src/test/results/clientpositive/join36.q.out 206d5ff
> ql/src/test/results/clientpositive/join37.q.out 5ee88f7
> ql/src/test/results/clientpositive/join38.q.out aca06b2
> ql/src/test/results/clientpositive/join39.q.out ee99675
> ql/src/test/results/clientpositive/join40.q.out 949c8fb
> ql/src/test/results/clientpositive/join_on_varchar.q.out ace445d
> ql/src/test/results/clientpositive/join_reorder.q.out 5cef0c9
> ql/src/test/results/clientpositive/join_reorder4.q.out c41407f
> ql/src/test/results/clientpositive/llap/bucketmapjoin1.q.out 93efa3c
> ql/src/test/results/clientpositive/llap/bucketmapjoin2.q.out cea632b
> ql/src/test/results/clientpositive/llap/bucketmapjoin3.q.out 4aa0e0e
> ql/src/test/results/clientpositive/llap/bucketmapjoin4.q.out 21ce1f8
> ql/src/test/results/clientpositive/llap/explainuser_1.q.out 53839a3
> ql/src/test/results/clientpositive/llap/join_filters.q.out b730d30
> ql/src/test/results/clientpositive/llap/join_nulls.q.out c9876d3
> ql/src/test/results/clientpositive/llap/skewjoin.q.out 1251b67
> ql/src/test/results/clientpositive/llap/smb_mapjoin_14.q.out 8dee9ff
> ql/src/test/results/clientpositive/llap/smb_mapjoin_15.q.out 20766c2
> ql/src/test/results/clientpositive/llap/smb_mapjoin_17.q.out a97a692
> ql/src/test/results/clientpositive/llap/smb_mapjoin_4.q.out 7d7d96d
> ql/src/test/results/clientpositive/llap/smb_mapjoin_5.q.out 1abe220
> ql/src/test/results/clientpositive/llap/smb_mapjoin_6.q.out bbf9b46
> ql/src/test/results/clientpositive/llap/stats11.q.out 3eccf52
> ql/src/test/results/clientpositive/llap/table_access_keys_stats.q.out 48ea4ce
> ql/src/test/results/clientpositive/mapjoin1.q.out 5601bc0
> ql/src/test/results/clientpositive/mapjoin_distinct.q.out d49c172
> ql/src/test/results/clientpositive/mapjoin_hook.q.out 8a6743c
> ql/src/test/results/clientpositive/pcs.q.out c422a3d
> ql/src/test/results/clientpositive/skewjoin.q.out e792381
> ql/src/test/results/clientpositive/spark/bucketmapjoin1.q.out 6333f2c
> ql/src/test/results/clientpositive/spark/bucketmapjoin2.q.out 58fe4ab
> ql/src/test/results/clientpositive/spark/bucketmapjoin3.q.out 06ce6f5
> ql/src/test/results/clientpositive/spark/bucketmapjoin4.q.out 94636f2
> ql/src/test/results/clientpositive/spark/join25.q.out bd44295
> ql/src/test/results/clientpositive/spark/join26.q.out 4a85a29
> ql/src/test/results/clientpositive/spark/join27.q.out 0dfad72
> ql/src/test/results/clientpositive/spark/join30.q.out 8360400
> ql/src/test/results/clientpositive/spark/join36.q.out 49167f3
> ql/src/test/results/clientpositive/spark/join37.q.out 231ca22
> ql/src/test/results/clientpositive/spark/join38.q.out 5177dca
> ql/src/test/results/clientpositive/spark/join39.q.out 5a5aeb4
> ql/src/test/results/clientpositive/spark/join_reorder.q.out eae5426
> ql/src/test/results/clientpositive/spark/join_reorder4.q.out 83ea4c5
> ql/src/test/results/clientpositive/spark/mapjoin1.q.out ca489e4
> ql/src/test/results/clientpositive/spark/mapjoin_distinct.q.out 6b3fcc0
> ql/src/test/results/clientpositive/spark/skewjoin.q.out dade580
> ql/src/test/results/clientpositive/spark/smb_mapjoin_14.q.out 68cd0fb
> ql/src/test/results/clientpositive/spark/smb_mapjoin_15.q.out 5372615
> ql/src/test/results/clientpositive/spark/smb_mapjoin_17.q.out 25e29f6
> ql/src/test/results/clientpositive/spark/smb_mapjoin_4.q.out 476971b
> ql/src/test/results/clientpositive/spark/smb_mapjoin_5.q.out be2ff37
> ql/src/test/results/clientpositive/spark/smb_mapjoin_6.q.out 5ae3845
> ql/src/test/results/clientpositive/spark/table_access_keys_stats.q.out 923441a
>
>
> Diff: https://reviews.apache.org/r/57738/diff/1/
>
>
> Testing
> -------
>
> Existing regression tests.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>