You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/20 19:45:27 UTC

[GitHub] [superset] suddjian commented on a change in pull request #17757: feat: Authorizing guest access to embedded dashboards

suddjian commented on a change in pull request #17757:
URL: https://github.com/apache/superset/pull/17757#discussion_r789098157



##########
File path: superset/security/api.py
##########
@@ -35,7 +35,7 @@ class UserSchema(Schema):
 
 
 class ResourceSchema(Schema):
-    type = fields.String(required=True)
+    type = fields.String(required=True)  # todo figure out how to make this an enum

Review comment:
       Even better, the `marshmallow_enum` package adds an `EnumField` https://github.com/apache/superset/pull/17836/files#diff-ddc89915e8af096a98449594cef72e9d33b26bfd37de6b549fd677000a24ee9bR52




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org