[GitHub] [airflow] uranusjr commented on a change in pull request #16141: Add a calendar field to choose the execution date of the DAG when triggering it

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #16141:
URL: https://github.com/apache/airflow/pull/16141#discussion_r661111766



##########
File path: airflow/www/decorators.py
##########
@@ -53,7 +54,10 @@ def wrapper(*args, **kwargs):
             )
 
             if 'execution_date' in request.values:
-                log.execution_date = pendulum.parse(request.values.get('execution_date'), strict=False)
+                try:
+                    log.execution_date = pendulum.parse(request.values.get('execution_date'), strict=False)
+                except ParserError:
+                    pass

Review comment:
       This silently discard an invalid `execution_date` value and I don’t think it’s a good thing. Why is this needed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org