You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/05/27 15:14:03 UTC
Review Request 21926: CLOUDSTACK-6782: Egress FW rules test cases - Format
unicode to string before string matching
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21926/
-----------------------------------------------------------
Review request for cloudstack and Santhosh Edukulla.
Bugs: CLOUDSTACK-6782
https://issues.apache.org/jira/browse/CLOUDSTACK-6782
Repository: cloudstack-git
Description
-------
Test cases are failing because unicode data does not match with string.
E.g. Script result is [u'100'] is not matching with ['100']
Current code converts it to string but when the result is a list, then we have to convert each item to string. Formatting list to string does not help.
Diffs
-----
test/integration/component/test_egress_fw_rules.py a42caa9
Diff: https://reviews.apache.org/r/21926/diff/
Testing
-------
Yes.
Log:
Test By-default the communication from guest n/w to public n/w is NOT allowed. ... === TestName: test_01_1_egress_fr1 | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 523.654s
OK
Thanks,
Gaurav Aradhye
Re: Review Request 21926: CLOUDSTACK-6782: Egress FW rules test cases -
Format unicode to string before string matching
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21926/#review44238
-----------------------------------------------------------
Commit b105a33e0c1d2cfe21442c3a3c2af762d9105574 in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b105a33 ]
CLOUDSTACK-6782: Egress FW rules test cases - Format unicode to string before string matching
- ASF Subversion and Git Services
On May 27, 2014, 1:14 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21926/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 1:14 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6782
> https://issues.apache.org/jira/browse/CLOUDSTACK-6782
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Test cases are failing because unicode data does not match with string.
> E.g. Script result is [u'100'] is not matching with ['100']
>
> Current code converts it to string but when the result is a list, then we have to convert each item to string. Formatting list to string does not help.
>
>
> Diffs
> -----
>
> test/integration/component/test_egress_fw_rules.py a42caa9
>
> Diff: https://reviews.apache.org/r/21926/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Log:
> Test By-default the communication from guest n/w to public n/w is NOT allowed. ... === TestName: test_01_1_egress_fr1 | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 523.654s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 21926: CLOUDSTACK-6782: Egress FW rules test cases -
Format unicode to string before string matching
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21926/#review44008
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On May 27, 2014, 1:14 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21926/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 1:14 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6782
> https://issues.apache.org/jira/browse/CLOUDSTACK-6782
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Test cases are failing because unicode data does not match with string.
> E.g. Script result is [u'100'] is not matching with ['100']
>
> Current code converts it to string but when the result is a list, then we have to convert each item to string. Formatting list to string does not help.
>
>
> Diffs
> -----
>
> test/integration/component/test_egress_fw_rules.py a42caa9
>
> Diff: https://reviews.apache.org/r/21926/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Log:
> Test By-default the communication from guest n/w to public n/w is NOT allowed. ... === TestName: test_01_1_egress_fr1 | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 523.654s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 21926: CLOUDSTACK-6782: Egress FW rules test cases -
Format unicode to string before string matching
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21926/#review44237
-----------------------------------------------------------
Commit 323de6823deda16ddafab5d79f18996c70130e2b in cloudstack's branch refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=323de68 ]
CLOUDSTACK-6782: Egress FW rules test cases - Format unicode to string before string matching
- ASF Subversion and Git Services
On May 27, 2014, 1:14 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21926/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 1:14 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6782
> https://issues.apache.org/jira/browse/CLOUDSTACK-6782
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Test cases are failing because unicode data does not match with string.
> E.g. Script result is [u'100'] is not matching with ['100']
>
> Current code converts it to string but when the result is a list, then we have to convert each item to string. Formatting list to string does not help.
>
>
> Diffs
> -----
>
> test/integration/component/test_egress_fw_rules.py a42caa9
>
> Diff: https://reviews.apache.org/r/21926/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Log:
> Test By-default the communication from guest n/w to public n/w is NOT allowed. ... === TestName: test_01_1_egress_fr1 | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 523.654s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>