You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2019/04/29 16:10:38 UTC

[Impala-ASF-CR] IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive 

Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13177


Change subject: IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive
......................................................................

IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

Before the fix "buidall.sh -asan -ubsan -tsan -tidy" ran without
giving any warning, but actually only tsan did have effect. Added
a check for this.

Change-Id: Iecaf1e1987a92dd911b30cf11b6e762320bdc4e5
---
M buildall.sh
1 file changed, 13 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/13177/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecaf1e1987a92dd911b30cf11b6e762320bdc4e5
Gerrit-Change-Number: 13177
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13177 )

Change subject: IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2969/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecaf1e1987a92dd911b30cf11b6e762320bdc4e5
Gerrit-Change-Number: 13177
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 18:45:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13177 )

Change subject: IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/2965/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/13177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecaf1e1987a92dd911b30cf11b6e762320bdc4e5
Gerrit-Change-Number: 13177
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 16:15:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13177 )

Change subject: IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecaf1e1987a92dd911b30cf11b6e762320bdc4e5
Gerrit-Change-Number: 13177
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Apr 2019 17:34:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13177 )

Change subject: IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecaf1e1987a92dd911b30cf11b6e762320bdc4e5
Gerrit-Change-Number: 13177
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 21:49:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13177 )

Change subject: IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive
......................................................................


Patch Set 2:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/2967/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/13177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecaf1e1987a92dd911b30cf11b6e762320bdc4e5
Gerrit-Change-Number: 13177
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 16:51:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13177

to look at the new patch set (#2).

Change subject: IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive
......................................................................

IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

Before the fix "buidall.sh -asan -ubsan -tsan -tidy" ran without
giving any warning, but actually only tsan did have effect. Added
a check for this.

Change-Id: Iecaf1e1987a92dd911b30cf11b6e762320bdc4e5
---
M buildall.sh
1 file changed, 15 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/13177/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iecaf1e1987a92dd911b30cf11b6e762320bdc4e5
Gerrit-Change-Number: 13177
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13177 )

Change subject: IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecaf1e1987a92dd911b30cf11b6e762320bdc4e5
Gerrit-Change-Number: 13177
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Apr 2019 12:12:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13177 )

Change subject: IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive
......................................................................

IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

Before the fix "buidall.sh -asan -ubsan -tsan -tidy" ran without
giving any warning, but actually only tsan did have effect. Added
a check for this.

Change-Id: Iecaf1e1987a92dd911b30cf11b6e762320bdc4e5
Reviewed-on: http://gerrit.cloudera.org:8080/13177
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M buildall.sh
1 file changed, 15 insertions(+), 7 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecaf1e1987a92dd911b30cf11b6e762320bdc4e5
Gerrit-Change-Number: 13177
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13177

to look at the new patch set (#3).

Change subject: IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive
......................................................................

IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

Before the fix "buidall.sh -asan -ubsan -tsan -tidy" ran without
giving any warning, but actually only tsan did have effect. Added
a check for this.

Change-Id: Iecaf1e1987a92dd911b30cf11b6e762320bdc4e5
---
M buildall.sh
1 file changed, 15 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/13177/3
-- 
To view, visit http://gerrit.cloudera.org:8080/13177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iecaf1e1987a92dd911b30cf11b6e762320bdc4e5
Gerrit-Change-Number: 13177
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13177 )

Change subject: IMPALA-8468: buildall.sh should warn that asan/ubsan/... are exclusive
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4116/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecaf1e1987a92dd911b30cf11b6e762320bdc4e5
Gerrit-Change-Number: 13177
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Apr 2019 12:12:41 +0000
Gerrit-HasComments: No