[GitHub] [tvm] tqchen commented on a change in pull request #7980: [METAL] Split kernels and compile them separately

[GitBox <gi...@apache.org>]

tqchen commented on a change in pull request #7980:
URL: https://github.com/apache/tvm/pull/7980#discussion_r630173046



##########
File path: src/runtime/metal/metal_module.mm
##########
@@ -71,6 +73,28 @@ void SaveToBinary(dmlc::Stream* stream) final {
       return "";
     }
   }
+
+  std::unordered_map<std::string, std::string> SplitKernels(std::string source) const {
+    std::unordered_map<std::string, std::string> split_kernels;

Review comment:
       cc @csullivan 

##########
File path: src/runtime/metal/metal_module.mm
##########
@@ -71,6 +73,28 @@ void SaveToBinary(dmlc::Stream* stream) final {
       return "";
     }
   }
+
+  std::unordered_map<std::string, std::string> SplitKernels(std::string source) const {
+    std::unordered_map<std::string, std::string> split_kernels;

Review comment:
       This is a duplicated util from https://github.com/apache/tvm/blob/main/src/runtime/opencl/opencl_module.cc#L245. consider move to a common one. e.g. src/runtime/source_utils.h




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org