You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "kasiazjc (via GitHub)" <gi...@apache.org> on 2024/04/02 15:08:56 UTC

Re: [PR] feat(viz picker): Remove some tags, refactor Recommended section [superset]

kasiazjc commented on PR #27708:
URL: https://github.com/apache/superset/pull/27708#issuecomment-2032313541

   > > My only non-blocking comment would be to replace the Featured icon with a ⭐
   > 
   > @yousoph @kasiazjc wdyt?
   
   @michael-s-molina also thought about ⭐️ at first, but we already use it for "favorites", so wanted to avoid duplicates. Sadly ant-d doesnt have the best choice for icons, but the other contenders (besides pin) would be: 
   <img width="179" alt="image" src="https://github.com/apache/superset/assets/36897697/20cf80a4-724b-43a2-baf7-4350ae1b72e7">
   or just 
   <img width="179" alt="image" src="https://github.com/apache/superset/assets/36897697/e9ac5677-5024-4483-b91e-93062f07c916">
    Thoughts @kgabryje @michael-s-molina ? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org