You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/13 21:16:21 UTC

[GitHub] [airflow] jameslamb opened a new pull request #18219: add more type hints in CeleryKubernetesExecutor

jameslamb opened a new pull request #18219:
URL: https://github.com/apache/airflow/pull/18219


   This PR proposes adding a few more type hints to places in `CeleryKubernetesExecutor` that are currently missing them.
   
   I think this change may improve the ability of static analysis tools like `mypy` to catch the types of issues caught by type checkers (e.g. attempting to apply a method that isn't compatible with a given object's type).
   
   ### Notes for Reviewers
   
   I'd like to submit more small PRs like this on other parts of the Airflow API where I see missing type hints. Would you support such contributions? Or are some places missing hints for reasons I don't understand, like limiting the cost of running type-checkers?
   
   Thanks very much for your time and consideration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jameslamb commented on pull request #18219: add more type hints in CeleryKubernetesExecutor

Posted by GitBox <gi...@apache.org>.
jameslamb commented on pull request #18219:
URL: https://github.com/apache/airflow/pull/18219#issuecomment-939228301


   Sorry for taking so long to return to this. I just updated this to latest `main`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #18219: add more type hints in CeleryKubernetesExecutor

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18219:
URL: https://github.com/apache/airflow/pull/18219


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #18219: add more type hints in CeleryKubernetesExecutor

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18219:
URL: https://github.com/apache/airflow/pull/18219#issuecomment-922345744


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18219: add more type hints in CeleryKubernetesExecutor

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18219:
URL: https://github.com/apache/airflow/pull/18219#issuecomment-939326167


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed pull request #18219: add more type hints in CeleryKubernetesExecutor

Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #18219:
URL: https://github.com/apache/airflow/pull/18219


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #18219: add more type hints in CeleryKubernetesExecutor

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18219:
URL: https://github.com/apache/airflow/pull/18219#issuecomment-922340178


   Reopening to rebuild.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jameslamb commented on pull request #18219: add more type hints in CeleryKubernetesExecutor

Posted by GitBox <gi...@apache.org>.
jameslamb commented on pull request #18219:
URL: https://github.com/apache/airflow/pull/18219#issuecomment-918589885


   I don't believe the failing CI build is related to this PR's changes.
   
   https://github.com/apache/airflow/pull/18219/checks?check_run_id=3592125119
   
   ```text
     ERROR: Cannot install apache-airflow[devel-ci]==2.2.0.dev0 because these package versions have conflicting dependencies.
     
     The conflict is caused by:
         apache-airflow[devel-ci] 2.2.0.dev0 depends on importlib_resources~=5.0
         The user requested (constraint) importlib-resources==1.5.0
     
     To fix this you could try to:
     1. loosen the range of package versions you've specified
     2. remove package versions to allow pip attempt to solve the dependency conflict
     
     ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies
     The command '/bin/bash -o pipefail -e -u -x -c if [[ ${INSTALL_FROM_PYPI} == "true" ]]; then         bash /scripts/docker/install_airflow.sh;     fi' returned a non-zero code: 1
   ```
   
   Looks like that might be coming from the changes in #18209


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org